Don't store translations for locales not set as available #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stereobooster
force-pushed
the
dont-store-tr-for-locales-not-set-as-available
branch
from
f64088a
to
5077ef9
Compare
radar
requested changes
Nov 8, 2017
One small change and then I think this is good to go. Thanks for rebasing it!
lib/i18n/backend/simple.rb
Outdated
| @@ -29,6 +29,11 @@ def initialized? | |||
| # translations will be overwritten by new ones only at the deepest | |||
| # level of the hash. | |||
| def store_translations(locale, data, options = {}) | |||
| if I18n.available_locales_initialized? && | |||
| I18n.available_locales.include?(locale.to_sym) == false && | |||
There was a problem hiding this comment.
Please use !I18n.available_locales.include?(locale.to_sym) here instead of == false.
|
@radar updated PR |
radar
approved these changes
Nov 9, 2017
|
LGTM! Thanks! |
Merged
tagliala
added a commit
to tagliala/faker
that referenced
this issue
Jan 27, 2018
Starting from version 0.9.3, I18n doesn't store translations for locales not set as available. This change set locales as available before storing translations. Fix: faker-ruby#1132 Ref: ruby-i18n/i18n#391
Closed
mshibuya
added a commit
to carrierwaveuploader/carrierwave
that referenced
this issue
Feb 10, 2018
I18n.available_locales needs to be cleared before storing translations: ruby-i18n/i18n#391
tagliala
added a commit
to tagliala/faker
that referenced
this issue
May 20, 2018
Starting from version 0.9.3, I18n doesn't store translations for locales not set as available. This change set locales as available before storing translations. Fix: faker-ruby#1132 Ref: ruby-i18n/i18n#391
tagliala
added a commit
to tagliala/faker
that referenced
this issue
Jun 21, 2018
Starting from version 0.9.3, I18n doesn't store translations for locales not set as available. This change set locales as available before storing translations. Fix: faker-ruby#1132 Ref: ruby-i18n/i18n#391
stympy
pushed a commit
to faker-ruby/faker
that referenced
this issue
Jun 21, 2018
Starting from version 0.9.3, I18n doesn't store translations for locales not set as available. This change set locales as available before storing translations. Fix: #1132 Ref: ruby-i18n/i18n#391
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this issue
Jul 12, 2021
Starting from version 0.9.3, I18n doesn't store translations for locales not set as available. This change set locales as available before storing translations. Fix: faker-ruby#1132 Ref: ruby-i18n/i18n#391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
rebased version of #261