Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate for arrays #395

Merged
merged 6 commits into from Jan 19, 2018
Merged

Conversation

@stereobooster
Copy link
Contributor

@stereobooster stereobooster commented Nov 9, 2017

rebased #282

@radar
Copy link
Collaborator

@radar radar commented Nov 15, 2017

Why do all that work and then close it?

@stereobooster
Copy link
Contributor Author

@stereobooster stereobooster commented Nov 15, 2017

I have more interest in merging other my PRs. And gem supporters clearly have limited resources to support project. Decided on my priorities.

@radar
Copy link
Collaborator

@radar radar commented Nov 15, 2017

@radar
Copy link
Collaborator

@radar radar commented Nov 19, 2017

Re-opening because there is interest in #282.

@radar
Copy link
Collaborator

@radar radar commented Nov 19, 2017

#396 is now closed, so this can be closed.

@radar radar closed this Nov 19, 2017
@fatkodima
Copy link
Contributor

@fatkodima fatkodima commented Jan 17, 2018

#396 is now closed, so this can be closed.

Am I missing the relationship between this PR and that PR? Looks like they are not related and it would be great to get this merged.

@radar radar reopened this Jan 18, 2018
@radar
radar approved these changes Jan 19, 2018
@radar radar merged commit c16460e into ruby-i18n:master Jan 19, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@radar
Copy link
Collaborator

@radar radar commented Jan 19, 2018

Yes, sorry. That was a typo on my end. Thanks @stereobooster and @fatkodima.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants