Minor 💅 for Net::LDAP instrumentation specs

Author: mtodd

spec/unit/ldap_spec.rb

@@ -2,18 +2,21 @@
 
 describe Net::LDAP do
   describe "initialize" do
-    context "on instrumentation_service configuration" do
+    context "when instrumentation is configured" do
       before do
         @tcp_socket = flexmock(:connection)
         @tcp_socket.should_receive(:close)
         flexmock(TCPSocket).should_receive(:new).and_return(@tcp_socket)
         @service = MockInstrumentationService.new
       end
 
-      it "should set the service object and instrument network calls" do
-        ldap = Net::LDAP.new(:server => 'test.mocked.com', :port => 636,
-                             :instrumentation_service => @service)
+      subject do
+        Net::LDAP.new \
+          :server => "test.mocked.com", :port => 636,
+          :instrumentation_service => @service
+      end
 
+      it "should set the service object and instrument network calls" do
         @tcp_socket.should_receive(:write).and_return(bytes_written = 1)
 
         write_events = @service.subscribe "write.net_ldap_connection"
@@ -24,7 +27,7 @@
         read_result = [2, ber]
         @tcp_socket.should_receive(:read_ber).and_return(read_result)
 
-        ldap.bind.should be_true
+        subject.bind.should be_true
 
         # a write event
         payload, result = write_events.pop