Skip to content

Commit 483af95

Browse files
committed
! Fixes references to various classes
I had to prefix all accesses to LdapPdu, AsnSyntax and Filter with Net::LDAP or Net:: respectively. We should rethink the module decomposition to make this more natural.
1 parent 97fbae9 commit 483af95

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

lib/net/ldap.rb

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1092,7 +1092,7 @@ def search_subschema_entry
10921092
#++
10931093
def paged_searches_supported?
10941094
@server_caps ||= search_root_dse
1095-
@server_caps[:supportedcontrol].include?(LdapControls::PagedResults)
1095+
@server_caps[:supportedcontrol].include?(Net::LDAP::LdapControls::PagedResults)
10961096
end
10971097
end # class LDAP
10981098

@@ -1173,7 +1173,7 @@ def setup_encryption(args)
11731173
request = [StartTlsOid.to_ber].to_ber_appsequence(Net::LdapPdu::ExtendedRequest)
11741174
request_pkt = [msgid, request].to_ber_sequence
11751175
@conn.write request_pkt
1176-
be = @conn.read_ber(AsnSyntax)
1176+
be = @conn.read_ber(Net::LDAP::AsnSyntax)
11771177
raise Net::LDAP::LdapError, "no start_tls result" if be.nil?
11781178
pdu = Net::LdapPdu.new(be)
11791179
raise Net::LDAP::LdapError, "no start_tls result" if pdu.nil?
@@ -1234,7 +1234,7 @@ def bind_simple(auth)
12341234
request_pkt = [msgid, request].to_ber_sequence
12351235
@conn.write request_pkt
12361236

1237-
(be = @conn.read_ber(AsnSyntax) and pdu = Net::LdapPdu.new(be)) or raise Net::LDAP::LdapError, "no bind result"
1237+
(be = @conn.read_ber(Net::LDAP::AsnSyntax) and pdu = Net::LdapPdu.new(be)) or raise Net::LDAP::LdapError, "no bind result"
12381238

12391239
pdu.result_code
12401240
end
@@ -1273,7 +1273,7 @@ def bind_sasl(auth)
12731273
request_pkt = [msgid, request].to_ber_sequence
12741274
@conn.write request_pkt
12751275

1276-
(be = @conn.read_ber(AsnSyntax) and pdu = Net::LdapPdu.new(be)) or raise Net::LDAP::LdapError, "no bind result"
1276+
(be = @conn.read_ber(Net::LDAP::AsnSyntax) and pdu = Net::LdapPdu.new(be)) or raise Net::LDAP::LdapError, "no bind result"
12771277
return pdu.result_code unless pdu.result_code == 14 # saslBindInProgress
12781278
raise Net::LDAP::LdapError, "sasl-challenge overflow" if ((n += 1) > MaxSaslChallenges)
12791279

@@ -1325,8 +1325,9 @@ def bind_gss_spnego(auth)
13251325
# in the protocol.
13261326
#++
13271327
def search(args = {})
1328-
search_filter = (args && args[:filter]) || Filter.eq("objectclass", "*")
1329-
search_filter = Filter.construct(search_filter) if search_filter.is_a?(String)
1328+
search_filter = (args && args[:filter]) ||
1329+
Net::LDAP::Filter.eq("objectclass", "*")
1330+
search_filter = Net::LDAP::Filter.construct(search_filter) if search_filter.is_a?(String)
13301331
search_base = (args && args[:base]) || "dc=example, dc=com"
13311332
search_attributes = ((args && args[:attributes]) || []).map { |attr| attr.to_s.to_ber}
13321333
return_referrals = args && args[:return_referrals] == true
@@ -1387,7 +1388,7 @@ def search(args = {})
13871388

13881389
controls = [
13891390
[
1390-
LdapControls::PagedResults.to_ber,
1391+
Net::LDAP::LdapControls::PagedResults.to_ber,
13911392
# Criticality MUST be false to interoperate with normal LDAPs.
13921393
false.to_ber,
13931394
rfc2696_cookie.map{ |v| v.to_ber}.to_ber_sequence.to_s.to_ber
@@ -1400,7 +1401,7 @@ def search(args = {})
14001401
result_code = 0
14011402
controls = []
14021403

1403-
while (be = @conn.read_ber(AsnSyntax)) && (pdu = LdapPdu.new(be))
1404+
while (be = @conn.read_ber(Net::LDAP::AsnSyntax)) && (pdu = Net::LdapPdu.new(be))
14041405
case pdu.app_tag
14051406
when 4 # search-data
14061407
n_results += 1
@@ -1435,7 +1436,7 @@ def search(args = {})
14351436
more_pages = false
14361437
if result_code == 0 and controls
14371438
controls.each do |c|
1438-
if c.oid == LdapControls::PagedResults
1439+
if c.oid == Net::LDAP::LdapControls::PagedResults
14391440
# just in case some bogus server sends us more than 1 of these.
14401441
more_pages = false
14411442
if c.value and c.value.length > 0
@@ -1477,7 +1478,7 @@ def modify(args)
14771478
pkt = [next_msgid.to_ber, request].to_ber_sequence
14781479
@conn.write pkt
14791480

1480-
(be = @conn.read_ber(AsnSyntax)) && (pdu = LdapPdu.new(be)) && (pdu.app_tag == 7) or raise Net::LDAP::LdapError, "response missing or invalid"
1481+
(be = @conn.read_ber(Net::LDAP::AsnSyntax)) && (pdu = Net::LdapPdu.new(be)) && (pdu.app_tag == 7) or raise Net::LDAP::LdapError, "response missing or invalid"
14811482
pdu.result_code
14821483
end
14831484

@@ -1499,7 +1500,7 @@ def add(args)
14991500
pkt = [next_msgid.to_ber, request].to_ber_sequence
15001501
@conn.write pkt
15011502

1502-
(be = @conn.read_ber(AsnSyntax)) && (pdu = LdapPdu.new(be)) && (pdu.app_tag == 9) or raise Net::LDAP::LdapError, "response missing or invalid"
1503+
(be = @conn.read_ber(Net::LDAP::AsnSyntax)) && (pdu = Net::LdapPdu.new(be)) && (pdu.app_tag == 9) or raise Net::LDAP::LdapError, "response missing or invalid"
15031504
pdu.result_code
15041505
end
15051506

@@ -1515,7 +1516,7 @@ def rename(args)
15151516
pkt = [next_msgid.to_ber, request].to_ber_sequence
15161517
@conn.write pkt
15171518

1518-
(be = @conn.read_ber(AsnSyntax)) && (pdu = LdapPdu.new(be)) && (pdu.app_tag == 13) or raise Net::LDAP::LdapError, "response missing or invalid"
1519+
(be = @conn.read_ber(Net::LDAP::AsnSyntax)) && (pdu = Net::LdapPdu.new(be)) && (pdu.app_tag == 13) or raise Net::LDAP::LdapError, "response missing or invalid"
15191520
pdu.result_code
15201521
end
15211522

@@ -1529,7 +1530,7 @@ def delete(args)
15291530
pkt = [next_msgid.to_ber, request].to_ber_sequence
15301531
@conn.write pkt
15311532

1532-
(be = @conn.read_ber(AsnSyntax)) && (pdu = LdapPdu.new(be)) && (pdu.app_tag == 11) or raise Net::LDAP::LdapError, "response missing or invalid"
1533+
(be = @conn.read_ber(Net::LDAP::AsnSyntax)) && (pdu = Net::LdapPdu.new(be)) && (pdu.app_tag == 11) or raise Net::LDAP::LdapError, "response missing or invalid"
15331534
pdu.result_code
15341535
end
15351536
end # class Connection

0 commit comments

Comments
 (0)