Changed back return values in API methods to match what documentation says #39

merged 1 commit into from Aug 28, 2012


None yet

3 participants


Commit 2763040 broke the API, returning always a PDU, when the docs states that the return value should be a boolean depending on the status of the operation performed.

@RoryO RoryO merged commit 8acd4ac into ruby-ldap:master Aug 28, 2012

@frsantos , Why did you change?
This change affects other gems which depends on net-ldap.


Commit 2763040 broke some API methods (like bind_as) and the contract between what their documentation says to return (a boolean) and the actual returned value (a PDU).

This commit reverted the changes in those API methods to return what its documentation said.


I got it. Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment