Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Fails to generate filter parser when given string includes multibyte chars. #66

Merged
merged 3 commits into from
Jul 22, 2013

Conversation

satoryu
Copy link
Collaborator

@satoryu satoryu commented May 16, 2013

Net::LDAP::Filter::FilterParser fails to parse when a given string includes multibyte chars such as Japanese characters.
But this should support it according to RFC-2254.

This commit is to fix this failure.

Tatsuya Sato added 3 commits May 15, 2013 01:50
Net::LDAP::Filter::FilterParser fails to parse when a given string
includes multibyte chars such as Japanese characters.
But this should support it according to RFC-2254.

This commit is to fix this failure.
@@ -755,7 +755,7 @@ def parse_filter_branch(scanner)
scanner.scan(/\s*/)
if op = scanner.scan(/<=|>=|!=|:=|=/)
scanner.scan(/\s*/)
if value = scanner.scan(/(?:[-\w*.+@=,#\$%&!'\s\xC3\x80-\xCA\xAF]|\\[a-fA-F\d]{2})+/)
if value = scanner.scan(/(?:[-\w*.+@=,#\$%&!'\s\xC3\x80-\xCA\xAF]|[^\x00-\x7F]|\\[a-fA-F\d]{2})+/u)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RoryO pushed a commit that referenced this pull request Jul 22, 2013
Bug Fix: Fails to generate filter parser when given string includes multibyte chars.
@RoryO RoryO merged commit 646cdce into ruby-ldap:master Jul 22, 2013
@satoryu satoryu deleted the fix_filter_parser branch August 1, 2013 07:14
astratto pushed a commit to astratto/ruby-net-ldap that referenced this pull request Dec 18, 2015
Bug Fix: Fails to generate filter parser when given string includes multibyte chars.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants