Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Factor out PointerIdentity #11

Merged
merged 1 commit into from Jan 17, 2013

Conversation

Projects
None yet
2 participants
Owner

whitequark commented Jan 15, 2013

This pull request has some backwards-incompatible change in semantics, but I doubt it will be a problem.

Particularly, if someone has subclassed, for example, LLVM::Function, and would be comparing an instance of that class with LLVM::Function with the same @ptr:

  • #== returns true,
  • #hash returns the same value, but
  • #eql? returns false

My change would cause #eql? to return true in this case.

I would say that this doesn't quite make sense, and is very unlikely to be an actual problem. I'm not sure that an ability to subclass LLVM::Stuff is valuable at all.

@whitequark whitequark referenced this pull request Jan 16, 2013

Merged

Add Target APIs #12

Owner

jvoorhis commented Jan 16, 2013

This looks good. I'm stretched thin at the moment, so I suggest you go ahead and merge it.

@jvoorhis jvoorhis merged commit 514b73f into ruby-llvm:master Jan 17, 2013

@whitequark whitequark deleted the unknown repository branch Jan 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment