Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Port chriswailes changes (#10) #16
This was referenced
Jan 21, 2013
added a commit
this pull request
Jan 22, 2013
Squashing may have been a poor choice for that reason. I chose to squash, however, to avoid knowingly adding a buggy commit to master.
Because we do not yet have comprehensive test coverage, for each new call to the generated FFI bindings, I used
I considered bouncing the request, but thought this would be easier. How would you recommend handling this in the future?
First, thank you for doing that. I've been going to ask you to review my PR explicitly, but forgot about it.
Second, I do not generally consider a buggy commit in master as a significant problem, provided that HEAD stays working at all times. If you do, I'd be fine with updating my pull requests, as the squashing just breaks history too much to be practical.