Overwrite ability #106

prog-supdex · 2023-01-05T11:49:59Z

Hello, @palkan!
Please, review my changes

What is the purpose of this pull request?

Support passing --overwrite to CLI for overwriting the original_file

What changes did you make? (overview)

Add the ability to parse --overwrite

Is there anything you'd like reviewers to focus on?

--overwrite ability will work only with --single-version argument. Without the argument --single-version overwrite mode will ignored

Checklist

I've added tests for this change
I've added a Changelog entry
I've updated a documentation/SUPPORTED_FEATURES.md

Closes #104

palkan

Thanks!

The implementation looks good to me; let's figure out the tests.

Also:

--overwrite ability will work only with --single-version argument

Can we display a warning if --overwrite is specified but --single-version is missing?

spec/cli/nextify_spec.rb

palkan · 2023-01-18T02:47:49Z

CHANGELOG.md

@@ -2,6 +2,12 @@

 ## master

+## 0.15.4 (2023-01-05)


We do not update versions in PRs

moved to ##master

palkan · 2023-01-18T02:48:08Z

README.md

@@ -219,6 +219,7 @@ Usage: ruby-next nextify DIRECTORY_OR_FILE [options]
    -o, --output=OUTPUT              Specify output directory or file or stdout
        --min-version=VERSION        Specify the minimum Ruby version to support
        --single-version             Only create one version of a file (for the earliest Ruby version)
+        --overwrite                  Overwrites the original file with one version of --single-version (Works with --single-version)


Suggested change

--overwrite Overwrites the original file with one version of --single-version (Works with --single-version)

--overwrite Overwrites the original file with one version of --single-version (works only with --single-version)

changed to

**works only with --single-version or --rewrite**

palkan · 2023-01-18T02:49:28Z

lib/ruby-next/commands/nextify.rb

@@ -210,6 +236,10 @@ def stdout?
      def single_version?
        single_version || specified_rewriters
      end
+
+      def overwrite_original_file?
+        single_version && overwrite_original_file


We can remove single_version from here, since we explicitly check for it presence after parsing

Suggested change

single_version && overwrite_original_file

overwrite_original_file

palkan · 2023-01-18T02:50:24Z

lib/ruby-next/commands/nextify.rb

@@ -108,6 +113,11 @@ def parse!(args)
          exit 2
        end

+        if @overwrite_original_file && !@single_version


I think, we should use single_version? here and also mention --rewriters (as an alternative to --single-version) in the message:

Suggested change

if @overwrite_original_file && !@single_version

if overwrite_original_file? && !single_version?

thanks!

done
Also added spec test for --overwrite and --rewrite args

…s. Add spec overwrite_original_file with --rewrite

prog-supdex · 2023-02-02T21:11:03Z

Hello @palkan
just a little notification, if you didn`t receive any notifications before :)

…ngPatternError, so we need load -ruby-next)

palkan

Thanks for your help!

I'll merge this and apply changes myself.

palkan · 2023-03-30T21:14:37Z

spec/cli/nextify_spec.rb

+        old_content = File.read(File.join(__dir__, "dummy", "transpile_me.rb"))
+        File.write(File.join(__dir__, "dummy", "overwrite", "transpile_me.rb"), old_content)


We can prepare a fixture in the before hook instead of restoring it in the after hook. This way, we can avoid duplicating the transpile_me.rb file.

palkan · 2023-03-30T21:15:24Z

lib/ruby-next/commands/nextify.rb

@@ -119,6 +124,11 @@ def parse!(args)
            end
          end

+        if overwrite_original_file? && !single_version?
+          $stdout.puts "--single-version and --rewrite are missing, --overwrite arg works only with --single-version or --rewrite"


The phrase "--single-version and --rewrite are missing" is confusing; it sounds like we need both

prog-supdex added 6 commits January 5, 2023 14:23

add ability to overwrite original file

8f006c5

add spec for overwrite ability

49994da

add option --overwrite to README

869c920

remove mistake

475caa6

remove useless spec

1cc583b

add changes to CHANGELOG

750109b

palkan requested changes Jan 7, 2023

View reviewed changes

spec/cli/nextify_spec.rb Outdated Show resolved Hide resolved

prog-supdex added 2 commits January 7, 2023 14:25

add check for missing argument --single-version and show error

755df86

rewrite spec for --overwrite

7ff7a59

palkan requested changes Jan 18, 2023

View reviewed changes

prog-supdex added 6 commits January 18, 2023 10:29

remove version

a53c27d

fix decription about feature

48c0b1d

little refactoring

5ff4a70

change descrioption, add about --rewrite

1f5fe78

add check ovewrite_original_file and single_version after set rewrite…

a02b7c8

…s. Add spec overwrite_original_file with --rewrite

little refactoring spec

f25d90f

prog-supdex requested a review from palkan January 18, 2023 14:40

prog-supdex added 2 commits February 19, 2023 14:06

fix specs for ruby v2.5 and v2.6 (these versions do not have NoMatchi…

4b77ed4

…ngPatternError, so we need load -ruby-next)

remove useless spaces in nextify_spec

7067ee8

dapi mentioned this pull request Mar 18, 2023

Feature: An option to rewrite file inplace for ruby-next nextify #104 #109

Closed

3 tasks

palkan force-pushed the master branch from eaee31d to 740b0d1 Compare March 30, 2023 15:47

palkan reviewed Mar 30, 2023

View reviewed changes

palkan merged commit 36dd9e7 into ruby-next:master Mar 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Overwrite ability #106

Overwrite ability #106

Uh oh!

prog-supdex commented Jan 5, 2023 •

edited by palkan

Loading

Uh oh!

palkan left a comment

Uh oh!

Uh oh!

palkan Jan 18, 2023

Uh oh!

prog-supdex Jan 18, 2023

Uh oh!

palkan Jan 18, 2023

Uh oh!

prog-supdex Jan 18, 2023

Uh oh!

palkan Jan 18, 2023

Uh oh!

prog-supdex Jan 18, 2023

Uh oh!

vovs03 Jan 26, 2023

Uh oh!

palkan Jan 18, 2023

Uh oh!

prog-supdex Jan 18, 2023

Uh oh!

prog-supdex commented Feb 2, 2023

Uh oh!

palkan left a comment

Uh oh!

palkan Mar 30, 2023

Uh oh!

palkan Mar 30, 2023

Uh oh!

Uh oh!

	--overwrite Overwrites the original file with one version of --single-version (Works with --single-version)
	--overwrite Overwrites the original file with one version of --single-version (works only with --single-version)

	single_version && overwrite_original_file
	overwrite_original_file

	if @overwrite_original_file && !@single_version
	if overwrite_original_file? && !single_version?

		old_content = File.read(File.join(__dir__, "dummy", "transpile_me.rb"))
		File.write(File.join(__dir__, "dummy", "overwrite", "transpile_me.rb"), old_content)

Overwrite ability #106

Overwrite ability #106

Uh oh!

Conversation

prog-supdex commented Jan 5, 2023 • edited by palkan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is the purpose of this pull request?

What changes did you make? (overview)

Is there anything you'd like reviewers to focus on?

Checklist

Uh oh!

palkan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prog-supdex commented Feb 2, 2023

Uh oh!

palkan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

prog-supdex commented Jan 5, 2023 •

edited by palkan

Loading