Support passing rewriters to CLI #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I will take a look later this week. |
palkan
reviewed
Jun 9, 2020
|
Thank you! I've just added change log entry. |
palkan
reviewed
Jun 12, 2020
| @@ -2,6 +2,11 @@ | |||
|
|
|||
| ## master | |||
|
|
|||
| - Support passing rewriters to CLI. ([@sl4vr][]) | |||
There was a problem hiding this comment.
Could you please also add the actual link to the bottom of this file? (Right now it's not working, cause shortcut is not defined)
There was a problem hiding this comment.
Oops I thought it's Github feature or something
palkan
approved these changes
Jun 12, 2020
Thanks a lot!
Awesome work
Marked task as done: https://cultofmartians.com/tasks/ruby-next-cli-rewriters.html#task (check if everything is correct).
And could you please send me your mailing address to my e-mail (should be on my GitHub profile), so we'll we able to send you some stuff someday)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What is the purpose of this pull request?
Support passing rewriters to CLI - #42
What changes did you make? (overview)
--list-rewritersand--rewriteoptions fornextifycommand.Is there anything you'd like reviewers to focus on?
I didn't dig into that, just supposed rewriters gonna rewrite. Also it just failed for me in other case.
Also this implementation requires
--edgeand--proposedflags to use and even list corresponding rewriters. If it's not supposed to be so, I can change that.Checklist