New version of rubocop (0.57.0) produced dependency conflicts #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tried to upgrade a dependency and got errors running Bundler.
It looks like there is a version conflict between two or more dependencies. Depfu doesn't try to solve these, as this would mean to update more than one dependency at a time.
Please take a look at the exact failure to figure out if this is something you need to work on.
The bundler error message was:
What changed?
✳️ rubocop ( → 0.57.0) · Repo · Changelog
Release Notes
From the Github release:
New features
Rails/BulkChangeTablecop. (@wata727)Style/AccessModifierDeclarationscop. (@brandonweiss)Style/UnneededConditioncop. (@balbesina)Layout/ClosingHeredocIndentationcop. (@siggymcfried)slashesstyle toRails/FilePathsince Ruby accepts forward slashes even on Windows. (@sunny)Layout/LeadingBlankLineschecks for empty lines at the beginning of a file. (@rrosenblum)Bug fixes
Style/SymbolArrayandStyle/WordArraynot working on arrays of size 1. (@TikiTDO)Rails/AssertNotto allow it to have failure message. (@koic)headersorenvkeyword arguments inRails/HttpPositionalArguments. (@rrosenblum)Style/BracesAroundHashParametersauto-correct going past the end of the file when the closing curly brace is on the last line of a file. (@EiNSTeiN-)Style/FrozenStringLiteralCommentwould be added to the second line if the first line is empty. (@rrosenblum)Layout/SpaceInsideReferenceBracketsaware ofno_spacewhen using nested reference brackets. (@koic)Style/MixinGroupingwhen method namedincludeaccepts block. (@Darhazer)Changes
--fix-layout/-xcommand line alias. (@scottmatthewman)Lint/SplatKeywordArgumentscop. (@koic)httpdateto acceptedRails/TimeZonemethods. (@cupakromer)xmlschemato acceptedRails/TimeZonemethods. (@koic)rake repltask tobin/consolecommand. (@koic)inherit_modework for default configuration too. (@jonas054)unicode/display_width. (@nroman-stripe)Commits
See the full diff on Github. The new version differs by 54 commits:
Cut RuboCop 0.57[Fix #5823] Add new `slashes` style to `Rails/FilePath` (#5835)Fix typo. Change preceeding to precedingFix Layout/LeadingBlankLines offensesAdd new cop Layout/LeadingBlankLinesFix the changelog[Fix #5936] Add new --fix-layout alias (#5937)Merge pull request #5948 from koic/revert_workaround_for_yard_0_9_13Revert "Workaround for broke Travis with YARD 0.9.13"[Fix #5799] Check only top-level includes on class/module defFix offenses with autocorrect and hand craftRevert autocorrected by #5557Change indentation rule for `Layout/ClosingHeredocIndentation`Test autocorrection `Rails/AssertNot` with a failure messageMinor organization of TravisCI scriptAdd new `Rails/BulkChangeTable` cop (#5881)Fix the changelog[Fix #5406] Add new `Layout/ClosingHeredocIndentation` cop (#5557)Fix the changelog[Fix #5803] Add Style/UnneededCondition cop (#5915)Rename access modifier methods for clarityAdd AccessModifierDeclarations copAdd examples for Style/NumericLiteralPrefix (#5941)Format examples for Style/UnneededPercentQ (#5940)Update the AppVeyor badgeUpdate the Travis CI badgeChange organization URL to rubocop-hqInclude unicode/display_width without string extensionsReplace our own JaroWinkler algorithm with jaro_winkler gemWorkaround for broke Travis with YARD 0.9.13[Fix #5917] Let inherit_mode work for default configuration too[Fix #5914] Fix false negative for `Layout/SpaceInsideReferenceBrackets`Fix bug in RangeHelp where range_by_whole_lines goes past end of buffer (#5908)Fix bug where the frozen string literal comment could have an empty line before itFix bug where Token#space_before? thinks there is space before the first lineTravis: use jruby-9.2.0.0Suppress stdout in testsUse the expect_offense helperAdds missing force-exclusion option to listMove REPL command from rake to binMove bindir from bin direcotry to exe directoryUse node_matcher for better readabilityUse the #heredoc? method[Fix #5897] Apply symbol and word array conversion to array of size 1[#4910] Add an example for `Style/UnneededPercentQ` (#5555)Add `xmlschema` to accepted `Rails/TimeZone` methods.Minor refactor to reduce variable_force stack use (#5870)Remove unnecessary `require 'rubygems'` since Ruby 1.9Fix indentation of closing squiggly heredocAdd `httpdate` to accepted Rails time zone methods (#5761)Remove the Gemnasium badgeFix `Rails/AssertNot` to allow it to have message (#5894)[Fix #5888] Do not register an offense for headers or env keyword args (#5893)[Fix #5887] Remove `Lint/SplatKeywordArguments` cop