Skip to content

Conversation

@klippx
Copy link
Contributor

@klippx klippx commented Jun 8, 2018

Real implementation of #390 (clock skew)

Changes

  • Read issued at from the actual token instead of using Time.now (client time)
  • Read expires_at from the actual token instead of using Time.now (client time) and adding expires_in to it
  • Take clock skew into consideration when checking if token is expired

In case the token is not a JWT token with the expected keys, the old functionality is intact (use Time.now)

Thanks to @Ashaeron for helping me :)

klippx added 6 commits June 7, 2018 15:52
@klippx klippx changed the title Time skew parse iat (alternative) Take time skew into consideration (alternative) Jun 8, 2018
@klippx klippx force-pushed the time-skew-parse-iat branch from 78317c0 to 5a1d55a Compare June 8, 2018 13:11
@coveralls
Copy link

coveralls commented Jun 8, 2018

Pull Request Test Coverage Report for Build 645

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 625: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@klippx klippx changed the title Take time skew into consideration (alternative) Take clock skew and min validity into consideration Jun 8, 2018
@klippx klippx force-pushed the time-skew-parse-iat branch from 57641a6 to ad6db03 Compare June 8, 2018 13:41
@klippx
Copy link
Contributor Author

klippx commented Jun 10, 2018

Actually, I don't believe this is right. I need to think more about this...

@klippx klippx closed this Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants