New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match www Instagram subdomain #52

Merged
merged 1 commit into from Dec 5, 2015

Conversation

Projects
None yet
3 participants
@javan
Contributor

javan commented Dec 1, 2015

Looks like Instagram is directing all traffic to its www subdomain now:

$ curl -I https://instagram.com/p/-wN1PMSB6_/
HTTP/1.1 301 MOVED PERMANENTLY
Location: https://www.instagram.com/p/-wN1PMSB6_/

Before this change:

>> OEmbed::Providers::Instagram.get("https://www.instagram.com/p/-wN1PMSB6_/")
OEmbed::NotFound: No embeddable content at 'https://www.instagram.com/p/-wN1PMSB6_/'

After:

>> OEmbed::Providers::Instagram.get("https://www.instagram.com/p/-wN1PMSB6_/")
=> #<OEmbed::Response::Rich:0x007fb877a98468 @fields={"provider_url"=>"https://www.instagram.com", "media_id"=>"1130464339519086271_904614", ...
@cazzerson

This comment has been minimized.

cazzerson commented Dec 3, 2015

+1 This fixes URLs from recent Instagram API responses.

metavida added a commit that referenced this pull request Dec 5, 2015

Merge pull request #52 from javan/instagram-www
Match www Instagram subdomain

@metavida metavida merged commit b6fb7e1 into ruby-oembed:master Dec 5, 2015

@metavida

This comment has been minimized.

Collaborator

metavida commented Dec 5, 2015

Thanks for the fix! I've been swamped lately with work & family. I'll try to get a new version on rubygems next week.

@cazzerson

This comment has been minimized.

cazzerson commented Dec 10, 2015

Thanks @metavida @javan. This release will fix image checks and some displays in Lentil.

@metavida

This comment has been minimized.

Collaborator

metavida commented Dec 13, 2015

Alrighty, ruby-oembed 0.9.0 is now on rubygems & includes this pull. Thanks again for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment