New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP transport, and examples #199

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@tlrobinson

tlrobinson commented Jun 19, 2014

No description provided.

@localshred

This comment has been minimized.

Show comment
Hide comment
@localshred

localshred Jun 30, 2014

Contributor

@tlrobinson Can you provide more context for this feature? I'm pretty hesitant to add another transport layer given the state of the current two we already support. On the roadmap is the desire to refactor the zmq and socket transport layers into their own supported gems. This would obviously require building a solidified client/server api to allow anyone to build their own plugins.

Contributor

localshred commented Jun 30, 2014

@tlrobinson Can you provide more context for this feature? I'm pretty hesitant to add another transport layer given the state of the current two we already support. On the roadmap is the desire to refactor the zmq and socket transport layers into their own supported gems. This would obviously require building a solidified client/server api to allow anyone to build their own plugins.

@rtyler

This comment has been minimized.

Show comment
Hide comment
@rtyler

rtyler Jul 7, 2014

@localshred The goal of this work was to allow @lookout to deploy protobuf RPC services inside of existing HTTP infrastructure (e.g. Jetty).

Alongside it, we developed elementary-rpc as an alternative HTTP-based Protobuf RPC client.

I'd love to get the servers/transport layer code moved out into a new gem but that feels like more surgery than some drive-by-contributors should be making.

If you've got a rough sketch of what you'd like to see, I'd be happy to help out but I don't want to do a bunch of work extracting that code only to have it not be something suitable in your opinion

rtyler commented Jul 7, 2014

@localshred The goal of this work was to allow @lookout to deploy protobuf RPC services inside of existing HTTP infrastructure (e.g. Jetty).

Alongside it, we developed elementary-rpc as an alternative HTTP-based Protobuf RPC client.

I'd love to get the servers/transport layer code moved out into a new gem but that feels like more surgery than some drive-by-contributors should be making.

If you've got a rough sketch of what you'd like to see, I'd be happy to help out but I don't want to do a bunch of work extracting that code only to have it not be something suitable in your opinion

@localshred

This comment has been minimized.

Show comment
Hide comment
@localshred

localshred Jul 7, 2014

Contributor

"Drive-by contributors" is the best term I have heard in a long time 😁 👍.

If you can commit to providing some support for this feature through the next few versions until it can be extracted I would be a lot more willing to merge. I'm concerned about adding another transport layer that I don't have my own running code behind and having to support issues or performance tuning.

Give me a bit to review the code and I'll likely have some changes.

Contributor

localshred commented Jul 7, 2014

"Drive-by contributors" is the best term I have heard in a long time 😁 👍.

If you can commit to providing some support for this feature through the next few versions until it can be extracted I would be a lot more willing to merge. I'm concerned about adding another transport layer that I don't have my own running code behind and having to support issues or performance tuning.

Give me a bit to review the code and I'll likely have some changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment