Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong canonical URI used for Identity context #5

Closed
wants to merge 1 commit into from

Conversation

@Gargron
Copy link

commented Oct 10, 2019

Fix #4

Fix #4
@gkellogg

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

If there can be confusion, you can add both urls, for example how it’s done with schema.org

@gkellogg

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

So, the files are autogenerated, and the property place to change is in the Rakefile. In this case, you probably want the following:

CONTEXTS = {
  ...
  identity:         ["http://w3id.org/identity/v1", "https://w3id.org/identity/v1"],
  ...
}

And then, re-run the gen_contexts task.

That should generate the context with the "http" scheme, but also cache requests if the "https" scheme is used.

gkellogg added a commit that referenced this pull request Oct 10, 2019
…ith canonicalization in JSON-LD.

Fixes #4. Fixes #5.
@gkellogg

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Fixed in 2adb1df.

@gkellogg gkellogg closed this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.