From 04d29dd6f8a0314aff93e3d980080dd7c1d8a8c6 Mon Sep 17 00:00:00 2001 From: Tom Johnson Date: Mon, 1 Feb 2016 15:42:49 -0800 Subject: [PATCH 1/2] Fix errant `subject` calls in Repository specs A few `subject` calls crept in where `mutable` or `dataset` should have been called instead. These references work fine where no parameters are required by the `Repository`, but don't test the object given by the caller and break for, e.g., `SPARQL::Client::Repository`. --- lib/rdf/spec/dataset.rb | 2 +- lib/rdf/spec/repository.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/rdf/spec/dataset.rb b/lib/rdf/spec/dataset.rb index e0b7c6c..8f83252 100644 --- a/lib/rdf/spec/dataset.rb +++ b/lib/rdf/spec/dataset.rb @@ -41,7 +41,7 @@ describe '#isolation_level' do it 'is an allowable isolation level' do expect(described_class::ISOLATION_LEVELS) - .to include(subject.isolation_level) + .to include(dataset.isolation_level) end end end diff --git a/lib/rdf/spec/repository.rb b/lib/rdf/spec/repository.rb index 4d98598..e753491 100644 --- a/lib/rdf/spec/repository.rb +++ b/lib/rdf/spec/repository.rb @@ -31,10 +31,10 @@ describe '#delete_insert' do it 'updates transactionally' do - expect(subject).to receive(:commit_transaction).and_call_original + expect(mutable).to receive(:commit_transaction).and_call_original statement = RDF::Statement(:s, RDF::URI.new("urn:predicate:1"), :o) - subject.delete_insert([statement], [statement]) + mutable.delete_insert([statement], [statement]) end end end From dd4d28de3d48e12b6961fa716aa93ac82a65e34c Mon Sep 17 00:00:00 2001 From: Tom Johnson Date: Mon, 1 Feb 2016 16:08:45 -0800 Subject: [PATCH 2/2] Fix `rdf-isomorphic` dependency on `develop` --- Gemfile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Gemfile b/Gemfile index f93dc3e..d06775f 100644 --- a/Gemfile +++ b/Gemfile @@ -2,7 +2,8 @@ source "http://rubygems.org" gemspec -gem "rdf", git: "git://github.com/ruby-rdf/rdf.git", branch: "develop" +gem "rdf", git: "git://github.com/ruby-rdf/rdf.git", branch: "develop" +gem "rdf-isomorphic", git: "git://github.com/ruby-rdf/rdf-isomorphic.git", branch: "develop" group :development do gem "wirble" @@ -15,4 +16,4 @@ end group :development, :test do gem 'simplecov', require: false, platform: :mri_21 # Travis doesn't understand 22 yet. gem 'coveralls', require: false, platform: :mri_21 # Travis doesn't understand 22 yet. -end \ No newline at end of file +end