New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favor ncursesw over curses #40

Merged
merged 3 commits into from Oct 16, 2018

Conversation

Projects
None yet
6 participants
@DivineDominion
Contributor

DivineDominion commented Sep 20, 2018

When ncursesw is available on a platform, you gain wide-character support (e.g. for box drawing characters) on Debian Linux machines if that's prioritized over the standard curses library (which will only print "garbage", as far as the user is concerned).

Since the API is compatible and ncursesw is supported by this gem, I think we should default to ncursesw instead.

@knu

This comment has been minimized.

Show comment
Hide comment
@knu

knu Sep 26, 2018

Member

@shugo What do you think of this, as a heavy user of curses? 😎

Member

knu commented Sep 26, 2018

@shugo What do you think of this, as a heavy user of curses? 😎

Show resolved Hide resolved curses.gemspec Outdated
@kaspergrubbe

This comment has been minimized.

Show comment
Hide comment
@kaspergrubbe

kaspergrubbe commented Oct 12, 2018

@DivineDominion Nice fix! :)

@freemo

This comment has been minimized.

Show comment
Hide comment
@freemo

freemo Oct 16, 2018

Any chance we can get some movement on this, my app has been halted for over a year due to this bug...

freemo commented Oct 16, 2018

Any chance we can get some movement on this, my app has been halted for over a year due to this bug...

@shugo shugo merged commit ce7cca6 into ruby:master Oct 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@amatsuda

This comment has been minimized.

Show comment
Hide comment
@amatsuda

amatsuda Oct 16, 2018

Member

🎉

Member

amatsuda commented Oct 16, 2018

🎉

@shugo

This comment has been minimized.

Show comment
Hide comment
@shugo

shugo Oct 16, 2018

Member

Sorry for the delay.
I'll release new version with this fix later.

Thank you!

Member

shugo commented Oct 16, 2018

Sorry for the delay.
I'll release new version with this fix later.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment