Skip to content

Conversation

@headius
Copy link
Contributor

@headius headius commented Nov 11, 2025

This will address #45 going forward, but releases with missing -java versions will need to be manually pushed.

@k0kubun
Copy link
Member

k0kubun commented Nov 11, 2025

Let's also add if: ${{ matrix.ruby == 'ruby' }} to the Create GitHub release step. Running it in both rubies marks one of these jobs as a failure.

Copy link
Member

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@headius
Copy link
Contributor Author

headius commented Nov 11, 2025

No real way to test this without merging and releasing, so I'll do that.

This will address ruby#45 going forward, but releases with
missing -java versions will need to be manually pushed.
@headius
Copy link
Contributor Author

headius commented Nov 11, 2025

Let's also add if: ${{ matrix.ruby == 'ruby' }} to the Create GitHub release step.

@k0kubun Done and re-pushed. I'll merge shortly.

@headius headius merged commit a864a96 into ruby:master Nov 11, 2025
21 checks passed
@headius headius deleted the push-jruby-gem branch November 11, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants