🥅 Validate #enable arguments are all atoms#699
Merged
Conversation
This still allows the argument to be a single string with multiple space-delimited arguments. It splits the string first, and validates the substrings.
nevans
added
bug
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still allows the argument to be a single string with multiple space-delimited arguments. It splits the string first, and validates the substrings.
Without this patch,
Net::IMAP#enableis vulnerable to the same type of CRLF injection issues as in CVE-2026-42258 (GHSA-75xq-5h9v-w6px) and CVE-2026-42257 (GHSA-hm49-wcqc-g2xg).Please note:
Net::IMAP#enableshould be never be called with untrusted input! The documentation clearly states that use of any unknown extensions may result in undefined behavior. Any application that sends untrusted input with#enablewill still have a security vulnerability, even after this PR. Nevertheless, CRLF command injection can and should be prevented!