Remove PowerAssert.trace
#55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy PowerAssert.trace functionality and its supporting tests and helper code. The changes include eliminating trace tests and the test_core_ext_helper, updating the Context class to replace sub-context variants, and adjusting related documentation and Gemfile entries.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/trace_test.rb | Removed tests that depended on PowerAssert.trace |
| test/test_helper.rb | Removed dependency on test_core_ext_helper |
| test/test_core_ext_helper.rb | Entire helper file related to PowerAssert.trace removed |
| lib/power_assert/context.rb | Updated Context initialization and removed legacy sub-context classes; updated error message |
| lib/power_assert.rb | Replaced call to BlockContext with direct Context instantiation and removed trace method |
| README.md | Removed reference to pry-byebug-power_assert |
| Gemfile | Removed the gem dependency for byebug |
| tp.return_value : | ||
| InspectedValue.new(SafeInspectable.new(tp.return_value).inspect) | ||
| @return_values << Value[method_id.to_s, val, locs[idx].lineno, nil] | ||
| @return_values << Value[method_id.to_s, val, locs.last.lineno, nil] |
There was a problem hiding this comment.
The variable 'method_id' is used but not defined in the current scope. Define 'method_id' or update the code to properly reference an existing identifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.