Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

call to_s on o.value, in case it is a symbol. #77

Closed
wants to merge 1 commit into
from

Conversation

2 participants

mcr commented Aug 7, 2012

I will write a test case to confirm this, but wanted feedback as to whether this was even the right thing.

Owner

tenderlove commented Aug 7, 2012

Calling to_s shouldn't be necessary. Please include a test case. Thanks!

mcr commented Aug 8, 2012

yes, wrote a test case, and to_s is not necessary. I found the origin of the problem: some changes we did in our application to Hash::encode_with() to sort the keys, since SortKeys is a no-op with psych.
If I add that monkey patch into test_hash.rb, my simple test case fails.

@mcr mcr closed this Aug 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment