Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a `last_comment` removal/deprecation warning for now #116

Closed
connorshea opened this issue Mar 9, 2016 · 8 comments

Comments

@connorshea
Copy link

commented Mar 9, 2016

NoMethodError: undefined method 'last_comment' for #<Rake::Application:0x00000002b87b38> tells me nothing. Can you please add a Use last_description method warning for now? It can be removed in v12, but this was kind of a surprise and I don't think most people were expecting it.

@kpheasey

This comment has been minimized.

Copy link

commented Mar 10, 2016

This caused me headaches with a Rails 5 engine and RubyMine configuration. A deprecation warning would have been great.

@bbatsov

This comment has been minimized.

Copy link

commented Mar 10, 2016

Supposedly this was deprecated a while back, although I haven't seen a deprecation message myself. Most projects quickly released updated rake tasks, with yard being one notable exception so far. It seems to me we're past the point of adding this back - just search for this on GitHub. :-)

@dsawa

This comment has been minimized.

Copy link

commented Mar 10, 2016

+1, wasn't expecting that.

On the other hand, for me it was enough to update rspec-rails.

For rails, if someone is using a gem that has not been updated yet, you can temporarly set gem 'rake', '< 11' in Gemfile.

@hsbt

This comment has been minimized.

Copy link
Member

commented Mar 11, 2016

I released Rake 11.1.0 with reverting to last_comment and deprecate it. I wiil remove it at Rake 12. Please report or submit patch to dependency of your application with deprecated usage.

@hsbt hsbt closed this Mar 11, 2016

@bronson

This comment has been minimized.

Copy link

commented Mar 11, 2016

@hsbt just curious, why did you remove last_comment? I can't find a reason in the commit or the issues. Patches to other projects should probably include why this change is necessary.

@connorshea

This comment has been minimized.

Copy link
Author

commented Mar 11, 2016

@hsbt thank you! :)

@bramski

This comment has been minimized.

Copy link

commented May 26, 2016

Would have been great if this deprecation included some context. I'm seeing this everytime I run rake.

[DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.
[DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.
[DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.
[DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.
[DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.
[DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.

I've grepped my whole codebase which would leave me with grepping my gems to figure out who hasn't upgraded yet. Sweet.

@hsbt

This comment has been minimized.

Copy link
Member

commented May 26, 2016

You need to upgrade rspec or rspec-rails.

@ruby ruby locked and limited conversation to collaborators May 26, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
7 participants
You can’t perform that action at this time.