Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support did_you_mean >= v1.2.0 which has a breaking change on formatters #262

Merged
merged 1 commit into from Mar 20, 2018

Conversation

gfx
Copy link
Contributor

@gfx gfx commented Mar 20, 2018

did_you_mean v1.2.0 has a breaking change to its formatter api:

ruby/did_you_mean@v1.1.2...v1.2.0

This PR uses the new DidYouMean.formatter, keeping backward compatibility for did_you_mean pre-1.2.0.

@gfx gfx force-pushed the did_you_mean-v1.2.0 branch from 7c01069 to a991099 Compare Mar 20, 2018
@gfx gfx force-pushed the did_you_mean-v1.2.0 branch from a991099 to 9d2c8af Compare Mar 20, 2018
@hsbt
Copy link
Member

hsbt commented Mar 20, 2018

Good catch. Thanks!

@hsbt hsbt merged commit a8ef9ac into ruby:master Mar 20, 2018
2 checks passed
@gfx gfx deleted the did_you_mean-v1.2.0 branch Mar 20, 2018
@yuki24
Copy link
Member

yuki24 commented Mar 21, 2018

Ah. This breaking change is totally unintentional and DYM should maintain the compatibility. I'll fix that in did_you_mean too. Thanks so much for taking care of this!

This was referenced Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants