Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: Reenabled task raises previous exception on second invokation #271

merged 2 commits into from Nov 12, 2019


Copy link

After a task is reenabled an exception of the pre-reenable invocation should not be raised but is.

lib/rake/task.rb Outdated
@@ -141,7 +141,8 @@ def arg_names
# Reenable the task, allowing its tasks to be executed if the task
# is invoked again.
def reenable
@already_invoked = false
@already_invoked = false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not super opinionated about this change, but this would slightly mess up git blame and sometimes it may be more annoying than just looking nice.

@hsbt hsbt merged commit b6e2a66 into ruby:master Nov 12, 2019
Copy link
Contributor Author

Thanks for merging @hsbt ❤️

@thorsteneckel thorsteneckel deleted the bugfix-reenable_invocation_exception branch November 12, 2019 07:23
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants