Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test fails caused by 2.6 warnings #297

Merged
merged 1 commit into from Dec 7, 2018
Merged

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Dec 7, 2018

Fixed broken tests with https://bugs.ruby-lang.org/issues/15231

@hsbt hsbt merged commit f0a897e into master Dec 7, 2018
5 checks passed
@hsbt hsbt deleted the ignore-warnings-2.6 branch Dec 7, 2018
@coveralls
Copy link

coveralls commented Dec 8, 2018

Coverage Status

Coverage decreased (-0.09%) to 97.471% when pulling 81763da on ignore-warnings-2.6 into 80e00e2 on master.

utilum added a commit to utilum/rails that referenced this issue Apr 18, 2019
Fixes railties ApplicationTests failures in Ruby 2.7.

Rake 12.3.2 includes a [Fix for test fails caused by 2.6 warnings](ruby/rake#297). Upadting prevents failures of:

- `RakeTests::RakeMigrationsTest#test_migration_status_when_schema_migrations_table_is_not_present`
- `RakeDbsTest#test_db:structure:dump_does_not_dump_schema_information_when_no_migrations_are_used`
- `BinSetupTest#test_bin_setup_output`

See [failures
log](https://gist.githubusercontent.com/utilum/30e081cc38b5d90e18be8cede6385b10/raw/2b89e568977d4f1fe010726a9a561c10e59c8df8/tests.log).

ruby 2.7.0dev (2019-04-18 trunk 67602) [x86_64-linux]
utilum added a commit to utilum/rails that referenced this issue Apr 18, 2019
Fixes railties ApplicationTests failures in Ruby 2.7.

Rake 12.3.2 includes a [Fix for test fails caused by 2.6 warnings](ruby/rake#297). Upadting prevents failures of:

- `RakeTests::RakeMigrationsTest#test_migration_status_when_schema_migrations_table_is_not_present`
- `RakeDbsTest#test_db:structure:dump_does_not_dump_schema_information_when_no_migrations_are_used`
- `BinSetupTest#test_bin_setup_output`

See [failures log](https://gist.githubusercontent.com/utilum/30e081cc38b5d90e18be8cede6385b10/raw/2b89e568977d4f1fe010726a9a561c10e59c8df8/tests.log).

ruby 2.7.0dev (2019-04-18 trunk 67602) [x86_64-linux]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants