Aliki Feedback

[Earlopain]

I'm playing around a bit with the new theme on https://docs.ruby-lang.org/en/master/ and have some thoughts I wanted to share. I like the theme toggle (dark mode specifically) and how the right side of my monitor is being used now. The search has more space to breath and doesn't take over the sidebar, with is nice.

Still, some complains/bugs:

Nested sections in the TOC are flattenend:

I guess it looses formatting since String is supposed to be code.

I'm also not particularly liking how the left sidebar now always contains the top-level pages. I will pretty much always scroll past that to get to the more important information. Perhaps that can be moved above "Class and Module Index", so that class-specific stuff comes first?

On mobile, the hamburger menu is selectable which is annoying when rapidly opening/closing it. I do that expecting the search to be there but it's actually always visible now (which I like!)

On mobile, the "On This Page" section is missing, or I at least didn't manage to find it.

On mobile, the hamburger menu starts out expanded and closes on page load so it always flashes briefly for me. Depends on network speed I guess. Sometimes it also closes immediatly after I click, although I'm not sure how to reproduce.

All that said, I'm a fan of how it looks now

[st0012]

Thanks for the clear feedback 🙂

Nested sections in the TOC are flattenend:

Yeah it'd be great to have it nested. I just don't have time to prioritize it yet. Do you mind opening an issue for this? PR is welcome too

I'm also not particularly liking how the left sidebar now always contains the top-level pages. I will pretty much always scroll past that to get to the more important information. Perhaps that can be moved above "Class and Module Index", so that class-specific stuff comes first?

Yeah I'm working on a solution for it. Currently I plan to make it collapse-able, and automatically collapse it outside of the index page.

I want to make the page docs more useful overtime, so I want to make it easily accessible.

On mobile, the hamburger menu is selectable which is annoying when rapidly opening/closing it.

Can you open a PR to help address this 🙂

On mobile, the "On This Page" section is missing, or I at least didn't manage to find it.

I can't think of a good way to display it on mobile. In the doc sites I used as reference, like Tailwind and React, they don't display ToC on mobile either.

I'm not against showing this information, but having another collapse-able sidebar on the right side should not be the solution IMO 😅

[Earlopain]

I opened two PRs with simple fixes.

Yeah I'm working on a solution for it. Currently I plan to make it collapse-able, and automatically collapse it outside of the index page.

That sounds fine to me.

I can't think of a good way to display it on mobile.

Rails guides has them directly at the start of the page. I'm not a big fan of that, it wastes quite a bit of space to get until the content. But not having them is a bit sad to me since I at least use them quite frequently.

A second sidebar doesn't make sense, agreed. But how about just adding it to the existing one and hide that section on desktop? That would mimick darkfish on mobile at least, what do you think?