New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store current timestamps in gz headers #569

Merged
merged 3 commits into from Jan 27, 2018

Conversation

2 participants
@bmwiedemann
Contributor

bmwiedemann commented Dec 14, 2017

to enable reproducible builds of rdoc

Normally, 0 would be the preferred value to indicate "no date"
but that value is handled differently in Zlib::GzipWriter
to put in the current time

Do not store current timestamps in gz headers
to enable reproducible builds of rdoc

Normally, 0 would be the preferred value to indicate "no date"
but that value is handled differently in Zlib::GzipWriter
to put in the current time
@aycabta

I think that it makes sense. Please check my review comments.

Show outdated Hide outdated lib/rdoc/generator/json_index.rb Outdated
Show outdated Hide outdated lib/rdoc/generator/json_index.rb Outdated

aycabta added some commits Jan 27, 2018

Improve reproducible builds for .js and .js.gz files
The mtime for search_index.js.gz should be updated because it's
generated dynamically. So uses SOURCE_DATE_EPOCH after
RDoc::Generator::JsonIndex#generate creates index file.

FileUtils.install in RDoc::Generator::JsonIndex#generate with :preserve
option because the mtime value is based on original .js file.

@aycabta aycabta merged commit 49f19bc into ruby:master Jan 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment