From 4edb676277ca69faf1a1e7a174e25803ba5825d6 Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Fri, 5 Jan 2024 17:50:01 -0800 Subject: [PATCH 1/4] Avoid failing CI on TruffleRuby --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 94c789fb..bcdbd33c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -27,6 +27,7 @@ jobs: WARMUP_ITRS: '1' MIN_BENCH_ITRS: '1' MIN_BENCH_TIME: '0' + continue-on-error: ${{ matrix.ruby == 'truffleruby-head' }} - name: Test run_once.sh run: ./run_once.sh --yjit-stats benchmarks/railsbench/benchmark.rb From 23b658e417b2a30d8d854b3792a59da328f4618b Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Mon, 8 Jan 2024 13:24:21 -0800 Subject: [PATCH 2/4] Just skip fluentd for truffleruby-head --- .github/workflows/test.yml | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index bcdbd33c..5770870b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -10,7 +10,10 @@ jobs: strategy: fail-fast: false matrix: - ruby: [ ruby, head, truffleruby-head ] + include: + - { ruby: ruby } + - { ruby: head } + - { ruby: truffleruby-head, skip: fluentd } steps: - uses: actions/checkout@v3 - name: Set up Ruby @@ -22,12 +25,16 @@ jobs: run: ruby test/benchmarks_test.rb - name: Test run_benchmarks.rb - run: ./run_benchmarks.rb + run: | + for benchmark in $SKIP_BENCHMARKS; do + rm -rf "benchmarks/${benchmark}.rb" "benchmarks/${benchmark}/" + done + ./run_benchmarks.rb env: WARMUP_ITRS: '1' MIN_BENCH_ITRS: '1' MIN_BENCH_TIME: '0' - continue-on-error: ${{ matrix.ruby == 'truffleruby-head' }} + SKIP_BENCHMARKS: ${{ matrix.skip }} - name: Test run_once.sh run: ./run_once.sh --yjit-stats benchmarks/railsbench/benchmark.rb From 88c5f38b7551ca866b6daccd09ff77b0536e0b1c Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Mon, 8 Jan 2024 13:37:00 -0800 Subject: [PATCH 3/4] liquid-c seems to be failing too --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5770870b..4915fb8d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -13,7 +13,7 @@ jobs: include: - { ruby: ruby } - { ruby: head } - - { ruby: truffleruby-head, skip: fluentd } + - { ruby: truffleruby-head, skip: "fluentd liquid-c" } steps: - uses: actions/checkout@v3 - name: Set up Ruby From 4a6481a46281fa1b4a7d2577653b26dfa5f2049a Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Mon, 8 Jan 2024 13:48:23 -0800 Subject: [PATCH 4/4] lobsters doesn't work either --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4915fb8d..91ba787b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -13,7 +13,7 @@ jobs: include: - { ruby: ruby } - { ruby: head } - - { ruby: truffleruby-head, skip: "fluentd liquid-c" } + - { ruby: truffleruby-head, skip: "fluentd liquid-c lobsters" } steps: - uses: actions/checkout@v3 - name: Set up Ruby