From 549fbd8e5ca7078db1f26a5044c8a6c06a33c19d Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Thu, 10 Jul 2025 16:17:06 +0200 Subject: [PATCH 1/3] Shipit: skip statistics page This controller uses a time based query (last 7 days deploys), so isn't suitable for benchmarking against a static dataset. --- benchmarks/shipit/route_generator.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/benchmarks/shipit/route_generator.rb b/benchmarks/shipit/route_generator.rb index 5cc1d2a4..ac5150a2 100644 --- a/benchmarks/shipit/route_generator.rb +++ b/benchmarks/shipit/route_generator.rb @@ -7,7 +7,6 @@ class RouteGenerator { num: 15, method: :GET, routes: ["/:stack_id"] }, # Stacks#show { num: 10, method: :GET, routes: [ "/:stack_id/tasks?since=33", # Paginated deploys - "/:stack_id/statistics", ]}, { num: 2, method: :GET, routes: [ "/:stack_id/settings" ]}, From 923cfa0c7701c8519c9ec7effd7e83e35596498f Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Thu, 10 Jul 2025 17:05:43 +0200 Subject: [PATCH 2/3] WIP --- multi_ractor.rb | 3 +++ run_benchmarks.rb | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 multi_ractor.rb diff --git a/multi_ractor.rb b/multi_ractor.rb new file mode 100644 index 00000000..67e7ff4a --- /dev/null +++ b/multi_ractor.rb @@ -0,0 +1,3 @@ +# Create a single ractor to force Ruby to use the multi_ractor_p paths. +Warning[:experimental] = false +Ractor.new { :noop } diff --git a/run_benchmarks.rb b/run_benchmarks.rb index a4eafbdc..e2fad399 100755 --- a/run_benchmarks.rb +++ b/run_benchmarks.rb @@ -312,7 +312,7 @@ def run_benchmarks(ruby:, ruby_description:, categories:, name_filters:, out_pat # Default values for command-line arguments args = OpenStruct.new({ executables: {}, - out_path: "./data", + out_path: File.expand_path("./data"), out_override: nil, harness: "harness", yjit_opts: "", From d5b818c9c4691532dae3d183721c20efbe71bf43 Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Fri, 11 Jul 2025 11:12:15 +0200 Subject: [PATCH 3/3] Add missing apt-get update before apt-get install --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index eab4cbf5..039fee24 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -42,6 +42,7 @@ jobs: - name: Test run_benchmarks.rb --graph run: | + sudo apt-get update sudo apt-get install -y --no-install-recommends libmagickwand-dev ./run_benchmarks.rb --graph fib if: matrix.ruby == 'ruby'