Skip to content

Extract parameters parser to its own object #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rafaelfranca merged 2 commits into from
Nov 21, 2025
Merged

Extract parameters parser to its own object #436

rafaelfranca merged 2 commits into from
Nov 21, 2025
+789 −160

Conversation

@rafaelfranca
Copy link
Collaborator

@rafaelfranca rafaelfranca commented Nov 20, 2025 •
edited
Loading

Extracting the parameter parsing to another object to make easier to test and make the code in run_benchmark.rb easier to understand.

@rafaelfranca rafaelfranca requested a review from a team November 20, 2025 21:15
tekknolagi
tekknolagi approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@tekknolagi tekknolagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@rafaelfranca rafaelfranca merged commit 5ad0531 into main Nov 21, 2025
3 checks passed
@rafaelfranca rafaelfranca deleted the rmf-argument-parser branch November 21, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tekknolagi tekknolagi tekknolagi approved these changes

@k0kubun k0kubun k0kubun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rafaelfranca @tekknolagi @k0kubun