Extract run_benchmarks to its own object, BenchmarkSuite
#438
+774
−292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is done inside a loop
This will avoid to calculate it inside the loop.
k0kubun
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This object is responsible for identifying which benchmarks should run and running them for the given executables. Today, all this lookup logic is made multiple times in the loop based on how many executables we have.
In a later refactor, this will be only done once in the execution of the script. This extraction helps with that.
Tests for this new object are also added.
@rwstauner the tests you just changes are removed in this PR, since it is redundant with the unit tests for the benchmark suite.