Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BUNDLER_VERSION env variable #5

Merged
merged 1 commit into from Aug 4, 2019

Conversation

@mtsmfm
Copy link
Contributor

commented Jul 29, 2019

Currently, bundler --version on ruby:2.7.0-preview-1-bionic doesn't work:

$ docker run rubylang/ruby:2.7.0-preview1-bionic bundler --version
/usr/local/lib/ruby/2.7.0/rubygems.rb:281:in `find_spec_for_exe': Could not find 'bundler' (1.17.3) required by `$BUNDLER_VERSION`. (Gem::GemNotFoundException)
To update to the latest version installed on your system, run `bundle update --bundler`.
To install the missing version, run `gem install bundler:1.17.3`
        from /usr/local/lib/ruby/2.7.0/rubygems.rb:300:in `activate_bin_path'
        from /usr/local/bin/bundler:23:in `<main>'

Because BUNDLER_VERSION restricts bundler version for bundler 2:
docker-library/ruby#246

On docker-library, it was already solved by removing BUNDLER_VERSION and installing newer rubygems:
docker-library/ruby#255

@yahonda yahonda referenced this pull request Jul 29, 2019
@yahonda

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

I'd like this pull request is reviewed by maintainers because this pull request should address rails/rails#36590 then Rails CI can run against Ruby 2.7.0 trunk.

@kou kou requested a review from mrkn Aug 3, 2019

@mrkn mrkn merged commit 8688893 into ruby:master Aug 4, 2019

yahonda added a commit to yahonda/ruby-docker-images that referenced this pull request Aug 6, 2019

yahonda added a commit to yahonda/ruby-docker-images that referenced this pull request Aug 8, 2019

Merge pull request ruby#5 from mtsmfm/master
Remove BUNDLER_VERSION env variable

yahonda added a commit to yahonda/ruby-docker-images that referenced this pull request Aug 15, 2019

Remove BUNDLER_VERSION environment variable
* No need to install bundler separately because `gem update --system 3.0.3` installs bundler 1.17.3

Refer one of the minor enhancements of RubyGems 3.0.2:

https://github.com/rubygems/rubygems/blob/919239f65daf74bce53935e191e0e57aabcb80a7/History.txt#L74

RubyGems 3.0.3 only has security fixes. No Bundler version bump found.

* Exporting `BUNDLER_VERSION=1.17.3` causes the error at Ruby 2.7.0 master
which installs `Bundler version 2.1.0.pre.1`

```
/usr/local/lib/ruby/2.7.0/rubygems.rb:281:in `find_spec_for_exe': Could not find 'bundler' (1.17.3) required by `$BUNDLER_VERSION`. (Gem::GemNotFoundException)
```

* Add a rough smoke test to show which RubyGem and Bundler versions installed

Refer ruby#5
Co-authored-by: Fumiaki MATSUSHIMA <mtsmfm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.