From 31137dc67fe60565a6023664a8e6e4ad35a362ad Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Mon, 13 Mar 2023 19:09:46 +0900 Subject: [PATCH] [rubygems/rubygems] Removed test for https://github.com/rubygems/rubygems/pull/6444, I have no idea to migrate this test to bundler example yet https://github.com/rubygems/rubygems/commit/0d869019bf --- lib/bundler/rubygems_ext.rb | 4 ++-- test/rubygems/test_gem_specification.rb | 25 ------------------------- 2 files changed, 2 insertions(+), 27 deletions(-) diff --git a/lib/bundler/rubygems_ext.rb b/lib/bundler/rubygems_ext.rb index ff3defa5b4c08f..35cc5b6cf8e343 100644 --- a/lib/bundler/rubygems_ext.rb +++ b/lib/bundler/rubygems_ext.rb @@ -83,8 +83,8 @@ def missing_extensions? # so we find them with heuristic way. We should improve it. if source.respond_to?(:root) return false if (full_require_paths - [extension_dir]).any? do |path| - File.exist?(File.join(path, "#{name}.#{RbConfig::CONFIG['DLEXT']}")) || - !Dir.glob(File.join(path, name, "*.#{RbConfig::CONFIG['DLEXT']}")).empty? + File.exist?(File.join(path, "#{name}.#{RbConfig::CONFIG["DLEXT"]}")) || + !Dir.glob(File.join(path, name, "*.#{RbConfig::CONFIG["DLEXT"]}")).empty? end end diff --git a/test/rubygems/test_gem_specification.rb b/test/rubygems/test_gem_specification.rb index 375d51cce50ae3..56ca7acaf272cf 100644 --- a/test/rubygems/test_gem_specification.rb +++ b/test/rubygems/test_gem_specification.rb @@ -3663,31 +3663,6 @@ def test_missing_extensions_eh_none refute @a1.missing_extensions? end - def test_missing_extensions_eh_local_gemspec - pend "extensions don't quite work on jruby" if Gem.java_platform? - - spec = new_default_spec "default", 1 - spec.extensions << "extconf.rb" - - ext_spec - @ext.name = spec.name - FileUtils.mkdir_p File.join(@ext.gem_dir, "lib") - - # ext_spec used empty extconf.rb, so we need to create dummy extension for rake-compiler case. - # Ex. lib/gemname.so - FileUtils.touch File.join(@ext.gem_dir, "lib", "#{@ext.name}.#{RbConfig::CONFIG['DLEXT']}") - - refute @ext.missing_extensions? - - # Try to another case of extconf.rb - # Ex. lib/gemname/parser.so - FileUtils.rm File.join(@ext.gem_dir, "lib", "#{@ext.name}.#{RbConfig::CONFIG['DLEXT']}") - FileUtils.mkdir_p File.join(@ext.gem_dir, "lib", @ext.name) - FileUtils.touch File.join(@ext.gem_dir, "lib", @ext.name, "parser.#{RbConfig::CONFIG['DLEXT']}") - - refute @ext.missing_extensions? - end - def test_find_all_by_full_name pl = Gem::Platform.new "i386-linux"