From 5831f7c83177d6214aee1165df694bb4d4ae8ec6 Mon Sep 17 00:00:00 2001 From: Takumasa Ochi Date: Mon, 8 May 2023 13:51:46 +0900 Subject: [PATCH] [rubygems/rubygems] Simplify code by Gem::Specification#runtime_dependencies https://github.com/rubygems/rubygems/commit/324139af8f --- lib/rubygems/specification.rb | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/lib/rubygems/specification.rb b/lib/rubygems/specification.rb index 8498dc636313b3..abdc1dbf4bd78f 100644 --- a/lib/rubygems/specification.rb +++ b/lib/rubygems/specification.rb @@ -1692,7 +1692,7 @@ def conflicts def conficts_when_loaded_with?(list_of_specs) # :nodoc: result = list_of_specs.any? do |spec| - spec.dependencies.any? {|dep| dep.runtime? && (dep.name == name) && !satisfies_requirement?(dep) } + spec.runtime_dependencies.any? {|dep| (dep.name == name) && !satisfies_requirement?(dep) } end result end @@ -1702,13 +1702,9 @@ def conficts_when_loaded_with?(list_of_specs) # :nodoc: def has_conflicts? return true unless Gem.env_requirement(name).satisfied_by?(version) - dependencies.any? do |dep| - if dep.runtime? - spec = Gem.loaded_specs[dep.name] - spec && !spec.satisfies_requirement?(dep) - else - false - end + runtime_dependencies.any? do |dep| + spec = Gem.loaded_specs[dep.name] + spec && !spec.satisfies_requirement?(dep) end rescue ArgumentError => e raise e, "#{name} #{version}: #{e.message}" @@ -2595,8 +2591,7 @@ def to_yaml(opts = {}) # :nodoc: def traverse(trail = [], visited = {}, &block) trail.push(self) begin - dependencies.each do |dep| - next unless dep.runtime? + runtime_dependencies.each do |dep| dep.matching_specs(true).each do |dep_spec| next if visited.key?(dep_spec) visited[dep_spec] = true