Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Method reference operator
Introduce the new operator for method reference, `.:`.
[Feature #12125] [Feature #13581]
[EXPERIMENTAL]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66667 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
  • Loading branch information
nobu committed Dec 31, 2018
1 parent 4a6f763 commit 67c5747
Show file tree
Hide file tree
Showing 15 changed files with 101 additions and 1 deletion.
3 changes: 3 additions & 0 deletions NEWS
Expand Up @@ -14,6 +14,9 @@ sufficient information, see the ChangeLog file or Redmine

=== Language changes

* Method reference operator, <code>.:</code> is introduced as an
experimental feature. [Feature #12125] [Feature #13581]

=== Core classes updates (outstanding ones only)

=== Stdlib updates (outstanding ones only)
Expand Down
3 changes: 3 additions & 0 deletions ast.c
Expand Up @@ -468,6 +468,9 @@ node_children(rb_ast_t *ast, NODE *node)
NEW_CHILD(ast, node->nd_args));
case NODE_VCALL:
return rb_ary_new_from_args(1, ID2SYM(node->nd_mid));
case NODE_METHREF:
return rb_ary_new_from_args(2, NEW_CHILD(ast, node->nd_recv),
ID2SYM(node->nd_mid));
case NODE_SUPER:
return rb_ary_new_from_node_args(ast, 1, node->nd_args);
case NODE_ZSUPER:
Expand Down
6 changes: 6 additions & 0 deletions compile.c
Expand Up @@ -4583,9 +4583,11 @@ defined_expr0(rb_iseq_t *iseq, LINK_ANCHOR *const ret,
case NODE_OPCALL:
case NODE_VCALL:
case NODE_FCALL:
case NODE_METHREF:
case NODE_ATTRASGN:{
const int explicit_receiver =
(type == NODE_CALL || type == NODE_OPCALL ||
type == NODE_METHREF ||
(type == NODE_ATTRASGN && !private_recv_p(node)));

if (!lfinish[1] && (node->nd_args || explicit_receiver)) {
Expand Down Expand Up @@ -7552,6 +7554,10 @@ iseq_compile_each0(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const NODE *node, in
}
break;
}
case NODE_METHREF:
CHECK(COMPILE_(ret, "receiver", node->nd_recv, popped));
ADD_ELEM(ret, &new_insn_body(iseq, line, BIN(methodref), 1, ID2SYM(node->nd_mid))->link);
break;
default:
UNKNOWN_NODE("iseq_compile_each", node, COMPILE_NG);
ng:
Expand Down
1 change: 1 addition & 0 deletions defs/id.def
Expand Up @@ -106,6 +106,7 @@ token_ops = %[\
ANDOP &&
OROP ||
ANDDOT &.
METHREF .:
]

class KeywordError < RuntimeError
Expand Down
1 change: 1 addition & 0 deletions ext/objspace/objspace.c
Expand Up @@ -471,6 +471,7 @@ count_nodes(int argc, VALUE *argv, VALUE os)
COUNT_NODE(NODE_DSYM);
COUNT_NODE(NODE_ATTRASGN);
COUNT_NODE(NODE_LAMBDA);
COUNT_NODE(NODE_METHREF);
#undef COUNT_NODE
case NODE_LAST: break;
}
Expand Down
1 change: 1 addition & 0 deletions ext/ripper/eventids2.c
Expand Up @@ -259,6 +259,7 @@ static const struct token_assoc {
{tSTAR, O(op)},
{tDSTAR, O(op)},
{tANDDOT, O(op)},
{tMETHREF, O(op)},
{tSTRING_BEG, O(tstring_beg)},
{tSTRING_CONTENT, O(tstring_content)},
{tSTRING_DBEG, O(embexpr_beg)},
Expand Down
10 changes: 10 additions & 0 deletions insns.def
Expand Up @@ -702,6 +702,16 @@ checktype
ret = (TYPE(val) == (int)type) ? Qtrue : Qfalse;
}

/* get method reference. */
DEFINE_INSN
methodref
(ID id)
(VALUE val)
(VALUE ret)
{
ret = rb_obj_method(val, ID2SYM(id));
}

/**********************************************************/
/* deal with control flow 1: class/module */
/**********************************************************/
Expand Down
9 changes: 9 additions & 0 deletions node.c
Expand Up @@ -934,6 +934,15 @@ dump_node(VALUE buf, VALUE indent, int comment, const NODE * node)
F_NODE(nd_args, "arguments");
return;

case NODE_METHREF:
ANN("method reference");
ANN("format: [nd_recv].:[nd_mid]");
ANN("example: foo.:method");
F_NODE(nd_recv, "receiver");
LAST_NODE;
F_ID(nd_mid, "method name");
return;

case NODE_LAMBDA:
ANN("lambda expression");
ANN("format: -> [nd_body]");
Expand Down
2 changes: 2 additions & 0 deletions node.h
Expand Up @@ -120,6 +120,7 @@ enum node_type {
NODE_DSYM,
NODE_ATTRASGN,
NODE_LAMBDA,
NODE_METHREF,
NODE_LAST
};

Expand Down Expand Up @@ -361,6 +362,7 @@ typedef struct RNode {
#define NEW_PREEXE(b,loc) NEW_SCOPE(b,loc)
#define NEW_POSTEXE(b,loc) NEW_NODE(NODE_POSTEXE,0,b,0,loc)
#define NEW_ATTRASGN(r,m,a,loc) NEW_NODE(NODE_ATTRASGN,r,m,a,loc)
#define NEW_METHREF(r,m,loc) NEW_NODE(NODE_METHREF,r,m,0,loc)

#define NODE_SPECIAL_REQUIRED_KEYWORD ((NODE *)-1)
#define NODE_REQUIRED_KEYWORD_P(node) ((node)->nd_value == NODE_SPECIAL_REQUIRED_KEYWORD)
Expand Down
28 changes: 27 additions & 1 deletion parse.y
Expand Up @@ -886,6 +886,7 @@ static void token_info_warn(struct parser_params *p, const char *token, token_in
%token tRSHFT RUBY_TOKEN(RSHFT) ">>"
%token <id> tANDDOT RUBY_TOKEN(ANDDOT) "&."
%token <id> tCOLON2 RUBY_TOKEN(COLON2) "::"
%token <id> tMETHREF RUBY_TOKEN(METHREF) ".:"
%token tCOLON3 ":: at EXPR_BEG"
%token <id> tOP_ASGN /* +=, -= etc. */
%token tASSOC "=>"
Expand Down Expand Up @@ -2710,6 +2711,13 @@ primary : literal
/*% %*/
/*% ripper: retry! %*/
}
| primary_value tMETHREF operation2
{
/*%%%*/
$$ = NEW_METHREF($1, $3, &@$);
/*% %*/
/*% ripper: methref!($1, $3) %*/
}
;

primary_value : primary
Expand Down Expand Up @@ -8060,12 +8068,30 @@ parser_yylex(struct parser_params *p)

case '.':
SET_LEX_STATE(EXPR_BEG);
if ((c = nextc(p)) == '.') {
switch (c = nextc(p)) {
case '.':
if ((c = nextc(p)) == '.') {
return tDOT3;
}
pushback(p, c);
return tDOT2;
case ':':
switch (c = nextc(p)) {
default:
if (!parser_is_identchar(p)) break;
/* fallthru */
case '!': case '%': case '&': case '*': case '+':
case '-': case '/': case '<': case '=': case '>':
case '[': case '^': case '`': case '|': case '~':
pushback(p, c);
SET_LEX_STATE(EXPR_DOT);
return tMETHREF;
case -1:
break;
}
pushback(p, c);
c = ':';
break;
}
pushback(p, c);
if (c != -1 && ISDIGIT(c)) {
Expand Down
7 changes: 7 additions & 0 deletions test/ripper/test_parser_events.rb
Expand Up @@ -434,6 +434,13 @@ def test_call
assert_equal "[call(ref(self),&.,foo,[])]", tree
end

def test_methref
thru_methref = false
tree = parse("obj.:foo", :on_methref) {thru_methref = true}
assert_equal true, thru_methref
assert_equal "[methref(vcall(obj),foo)]", tree
end

def test_excessed_comma
thru_excessed_comma = false
parse("proc{|x,|}", :on_excessed_comma) {thru_excessed_comma = true}
Expand Down
2 changes: 2 additions & 0 deletions test/ripper/test_scanner_events.rb
Expand Up @@ -550,6 +550,8 @@ def test_op
scan('op', ':[]=')
assert_equal ['&.'],
scan('op', 'a&.f')
assert_equal %w(.:),
scan('op', 'obj.:foo')
assert_equal [],
scan('op', %q[`make all`])
end
Expand Down
9 changes: 9 additions & 0 deletions test/ruby/test_ast.rb
Expand Up @@ -249,4 +249,13 @@ def test_defs
assert_equal(:b, mid)
assert_equal(:SCOPE, defn.type)
end

def test_methref
node = RubyVM::AbstractSyntaxTree.parse("obj.:foo")
_, _, body = *node.children
assert_equal(:METHREF, body.type)
recv, mid = body.children
assert_equal(:VCALL, recv.type)
assert_equal(:foo, mid)
end
end
19 changes: 19 additions & 0 deletions test/ruby/test_method.rb
Expand Up @@ -1095,4 +1095,23 @@ def f(x) x * 2 end
(f >> 5).call(2)
}
end

def test_method_reference_operator
m = 1.:succ
assert_equal(1.method(:succ), m)
assert_equal(2, m.())
m = 1.:+
assert_equal(1.method(:+), m)
assert_equal(42, m.(41))
m = 1.:-@
assert_equal(1.method(:-@), m)
assert_equal(-1, m.())
o = Object.new
def o.foo; 42; end
m = o.method(:foo)
assert_equal(m, o.:foo)
def o.method(m); nil; end
assert_equal(m, o.:foo)
assert_nil(o.method(:foo))
end
end
1 change: 1 addition & 0 deletions test/ruby/test_syntax.rb
Expand Up @@ -908,6 +908,7 @@ def test_invalid_symbol_space
def test_fluent_dot
assert_valid_syntax("a\n.foo")
assert_valid_syntax("a\n&.foo")
assert_valid_syntax("a\n.:foo")
end

def test_no_warning_logop_literal
Expand Down

0 comments on commit 67c5747

Please sign in to comment.