From 783f1b29087f4e8f11b873c1657dd927b0ecdd49 Mon Sep 17 00:00:00 2001 From: nagachika Date: Tue, 6 Nov 2018 15:52:16 +0000 Subject: [PATCH] merge revision(s) 65554: [Backport #15282] Don't set throw data as cause [Bug #15282] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@65582 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- eval.c | 2 +- test/ruby/test_exception.rb | 6 ++++++ version.h | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/eval.c b/eval.c index 3fa538e112aff2..d2860d09d0a425 100644 --- a/eval.c +++ b/eval.c @@ -516,7 +516,7 @@ setup_exception(rb_execution_context_t *ec, int tag, volatile VALUE mesg, VALUE mesg = rb_obj_dup(mesg); } } - if (cause != Qundef) { + if (cause != Qundef && !THROW_DATA_P(cause)) { exc_setup_cause(mesg, cause); } if (NIL_P(bt)) { diff --git a/test/ruby/test_exception.rb b/test/ruby/test_exception.rb index 862d46dc3c37eb..605248aebdddfc 100644 --- a/test/ruby/test_exception.rb +++ b/test/ruby/test_exception.rb @@ -698,6 +698,12 @@ def test_cause_at_raised assert_same(a, e.cause.cause) end + def test_cause_at_end + assert_in_out_err([], <<-'end;', [], [/-: unexpected return\n/, /.*undefined local variable or method `n'.*\n/]) + END{n}; END{return} + end; + end + def test_raise_with_cause msg = "[Feature #8257]" cause = ArgumentError.new("foobar") diff --git a/version.h b/version.h index 8e0f2a198e8e7a..b4dfbbde1d7d69 100644 --- a/version.h +++ b/version.h @@ -1,6 +1,6 @@ #define RUBY_VERSION "2.5.4" #define RUBY_RELEASE_DATE "2018-11-07" -#define RUBY_PATCHLEVEL 110 +#define RUBY_PATCHLEVEL 111 #define RUBY_RELEASE_YEAR 2018 #define RUBY_RELEASE_MONTH 11