Permalink
Browse files

* lib/net/smtp.rb: Added Net::SMTP#rset method to implement the SMTP

  RSET command.  [ruby-trunk - Feature #5373]
* NEWS:  ditto.
* test/net/smtp/test_smtp.rb:  Test for the above.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39729 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
  • Loading branch information...
1 parent b1f2eff commit f2a13e60d95c7be55de2fa793a186f5a63a9c142 @drbrain drbrain committed Mar 11, 2013
Showing with 42 additions and 0 deletions.
  1. +7 −0 ChangeLog
  2. +4 −0 NEWS
  3. +6 −0 lib/net/smtp.rb
  4. +25 −0 test/net/smtp/test_smtp.rb
View
7 ChangeLog
@@ -1,3 +1,10 @@
+Tue Mar 12 02:25:19 2013 Eric Hodel <drbrain@segment7.net>
+
+ * lib/net/smtp.rb: Added Net::SMTP#rset method to implement the SMTP
+ RSET command. [ruby-trunk - Feature #5373]
+ * NEWS: ditto.
+ * test/net/smtp/test_smtp.rb: Test for the above.
+
Mon Mar 11 22:44:57 2013 Tanaka Akira <akr@fsij.org>
* lib/resolv-replace.rb (TCPSocket#initialize): resolve the 3rd
View
4 NEWS
@@ -25,5 +25,9 @@ with all sufficient information, see the ChangeLog file.
The ancestors of a singleton class now include that singleton class.
=== Stdlib updates (outstanding ones only)
+
+* Net::SMTP
+ * Added Net::SMTP#rset to implement the RSET comamnd
+
=== Stdlib compatibility issues (excluding feature bug fixes)
=== C API updates
View
6 lib/net/smtp.rb
@@ -815,6 +815,12 @@ def cram_secret(secret, mask)
public
+ # Aborts the current mail transaction
+
+ def rset
+ getok('RSET')
+ end
+
def starttls
getok('STARTTLS')
end
View
25 test/net/smtp/test_smtp.rb
@@ -1,8 +1,26 @@
require 'net/smtp'
+require 'stringio'
require 'minitest/autorun'
module Net
class TestSMTP < MiniTest::Unit::TestCase
+ class FakeSocket
+ def initialize out = "250 OK\n"
+ @write_io = StringIO.new
+ @read_io = StringIO.new out
+ end
+
+ def writeline line
+ @write_io.write "#{line}\r\n"
+ end
+
+ def readline
+ line = @read_io.gets
+ raise 'ran out of input' unless line
+ line.chop
+ end
+ end
+
def test_esmtp
smtp = Net::SMTP.new 'localhost', 25
assert smtp.esmtp
@@ -12,5 +30,12 @@ def test_esmtp
assert_equal 'omg', smtp.esmtp
assert_equal 'omg', smtp.esmtp?
end
+
+ def test_rset
+ smtp = Net::SMTP.new 'localhost', 25
+ smtp.instance_variable_set :@socket, FakeSocket.new
+
+ assert smtp.rset
+ end
end
end

0 comments on commit f2a13e6

Please sign in to comment.