Skip to content

Conversation

@BurdetteLamar
Copy link
Member

Treats:

  • #begin
  • #end
  • #match
  • #match_length

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Apr 18, 2022
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change requested, then can be merged without additional review.

re.c Outdated
* match_length(n) -> integer or nil
* match_length(name) -> integer or nil
*
* Returns the length of the matched substring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably specify length is in characters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@BurdetteLamar BurdetteLamar merged commit b074bc3 into ruby:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants