Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YJIT: No need to fill to get UDF on ARM64 #6536

Merged
merged 1 commit into from Oct 13, 2022
Merged

Conversation

XrXr
Copy link
Member

@XrXr XrXr commented Oct 12, 2022

On ARM64, all zeros is already undefined, so we don't need to do extra work to fill new memory with undefined instructions.
https://developer.arm.com/documentation/ddi0596/2020-12/Base-Instructions/UDF--Permanently-Undefined-

@matzbot matzbot requested a review from a team October 12, 2022 20:23
Copy link
Contributor

@maximecb maximecb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Alan. This is a nice little improvement 👌

On ARM64, all zeros is already undefined, so we don't need to do extra
work to fill new memory with undefined instructions.
@XrXr XrXr merged commit 1b0c9d0 into ruby:master Oct 13, 2022
@XrXr XrXr deleted the yjit-arm64-fill branch October 13, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants