Fix bug in array pack with shared strings #6704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseaton
reviewed
Nov 9, 2022
test/ruby/test_array.rb
Outdated
| def test_pack_with_buffer | ||
| # Fixes [Bug #19116] | ||
| n = [ 65, 66, 67 ] | ||
| super_long_string = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" |
There was a problem hiding this comment.
The key thing here is that this string is shared isn't it? Can we deliberately create it as shared, and assert that it's shared, in this test, so that if sharing heuristics change the test doesn't stop testing what we think it does.
peterzhu2118
reviewed
Nov 9, 2022
jemmaissroff
force-pushed
the
pack-pack-fix
branch
2 times, most recently
from
dd05562
to
56b5af2
Compare
nobu
reviewed
Nov 9, 2022
jemmaissroff
force-pushed
the
pack-pack-fix
branch
from
56b5af2
to
7e7f55d
Compare
nobu
reviewed
Nov 10, 2022
test/ruby/test_array.rb
Outdated
Comment on lines
1298
to
1301
| # Fixes [Bug #19116] | ||
| n = [ 65, 66, 67 ] | ||
| str = "a" * 100 | ||
| assert_equal("aaaABC", n.pack("@3ccc", buffer: str.dup)) |
There was a problem hiding this comment.
A proper message would be better than a comment.
Suggested change
| # Fixes [Bug #19116] | |
| n = [ 65, 66, 67 ] | |
| str = "a" * 100 | |
| assert_equal("aaaABC", n.pack("@3ccc", buffer: str.dup)) | |
| n = [ 65, 66, 67 ] | |
| str = "a" * 100 | |
| assert_equal("aaaABC", n.pack("@3ccc", buffer: str.dup), "[Bug #19116]") |
jemmaissroff
force-pushed
the
pack-pack-fix
branch
from
7e7f55d
to
1d8f78e
Compare
nobu
reviewed
Nov 10, 2022
jemmaissroff
force-pushed
the
pack-pack-fix
branch
from
1d8f78e
to
f42a249
Compare
If string literals are long and they become shared, we need to make them independent before we can write to them. [Bug #19116]
jemmaissroff
force-pushed
the
pack-pack-fix
branch
from
f42a249
to
42a6e41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If string literals are long and they become shared, we need to make them independent before we can write to them. [Bug #19116]
Confirmed that the test added was previously failing, and is now passing.