Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

win32: VT100 escape #125

Merged
merged 1 commit into from Jun 4, 2012

Conversation

3 participants
Member

nobu commented May 11, 2012

for Feature #6418

Member

luislavena commented May 18, 2012

@nobu as commented on Redmine:

https://gist.github.com/2655794

ruby 2.0.0dev (2012-05-11 trunk 35616) [i386-mingw32]
1950 tests, 1650 assertions, 150 failures, 0 errors, 300 skips

# DEFAULT
Finished tests in 1.348063s, 1446.5199 tests/s, 1223.9784 assertions/s.

# PRIDE
Finished tests in 1.458083s, 1337.3724 tests/s, 1131.6228 assertions/s.

# ANSICON
Finished tests in 1.612092s, 1209.6084 tests/s, 1023.5148 assertions/s.

# With ANSI patch
Fabulous tests in 1.409676s, 1383.2966 tests/s, 1170.4817 assertions/s.

===

Redirected (> output.log)

# DEFAULT
Finished tests in 1.083062s, 1800.4509 tests/s, 1523.4585 assertions/s.

# PRIDE
Finished tests in 1.067061s, 1827.4494 tests/s, 1546.3034 assertions/s.

# ANSICON
Finished tests in 1.216070s, 1603.5261 tests/s, 1356.8298 assertions/s.

# With ANSI patch
Finished tests in 1.060061s, 1839.5168 tests/s, 1556.5142 assertions/s.

Seems no major performance degradation happened.

What else do we need to get this in?

Thank you.

@nobu nobu win32: VT100 escape
* win32/win32.c (constat_apply): apply VT100 functions.
  [ruby-core:44958] [Feature #6418]
* win32/win32.c (constat_parse): parse some VT100 escape sequence.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
82aa434

@shyouhei shyouhei merged commit 82aa434 into ruby:trunk Jun 4, 2012

@tenderlove tenderlove added a commit that referenced this pull request Apr 5, 2013

@tenderlove tenderlove * ext/psych/lib/psych/exception.rb: there should be only one exception
  base class. Fixes tenderlove/psych #125
* ext/psych/lib/psych.rb: require the correct exception class
* ext/psych/lib/psych/syntax_error.rb: ditto
* ext/psych/lib/psych/visitors/to_ruby.rb: ditto

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@40139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
476a62f

@tenderlove tenderlove added a commit to tenderlove/ruby that referenced this pull request Jan 24, 2014

@tenderlove tenderlove * ext/psych/lib/psych/exception.rb: there should be only one exception
  base class. Fixes tenderlove/psych #125
* ext/psych/lib/psych.rb: require the correct exception class
* ext/psych/lib/psych/syntax_error.rb: ditto
* ext/psych/lib/psych/visitors/to_ruby.rb: ditto

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@40139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
447e058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment