lib/mkmf.rb: sort list of object files in generated Makefile #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without sorting the list explicitely, its order is indeterministic, because readdir() is also not deterministic. When the list of object files varies between builds, they are linked in a different order, which results in an unreproducible build.
|
Can this fix please also be backported to the 2.3 branch? |
|
What do you mean by "an unreproducible build"? |
|
@nobu I mean that the resulting binaries will not be bit-identical on different build runs, when the objects are not sorted. This patch was already backported to Debian's ruby 2.3. |
nobu
added a commit
to nobu/ruby
that referenced
this pull request
Jun 4, 2016
* lib/mkmf.rb (create_makefile): sort lists of source and object files in generated Makefile, unless given by extconf.rb. [Fix rubyGH-1367] Without sorting the list of object files explicitely, its order is indeterministic, because readdir() is also not deterministic. When the list of object files varies between builds, they are linked in a different order, which results in an unreproducible build. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
rhenium
pushed a commit
to rhenium/ruby
that referenced
this pull request
Jun 11, 2016
* lib/mkmf.rb (create_makefile): sort lists of source and object files in generated Makefile, unless given by extconf.rb. [Fix rubyGH-1367] Without sorting the list of object files explicitely, its order is indeterministic, because readdir() is also not deterministic. When the list of object files varies between builds, they are linked in a different order, which results in an unreproducible build. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mrkn
pushed a commit
to mrkn/ruby
that referenced
this pull request
Jun 13, 2016
* lib/mkmf.rb (create_makefile): sort lists of source and object files in generated Makefile, unless given by extconf.rb. [Fix rubyGH-1367] Without sorting the list of object files explicitely, its order is indeterministic, because readdir() is also not deterministic. When the list of object files varies between builds, they are linked in a different order, which results in an unreproducible build. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@55265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlove
pushed a commit
to tenderlove/ruby
that referenced
this pull request
Jul 11, 2016
* lib/mkmf.rb (create_makefile): sort lists of source and object files in generated Makefile, unless given by extconf.rb. [Fix rubyGH-1367] Without sorting the list of object files explicitely, its order is indeterministic, because readdir() is also not deterministic. When the list of object files varies between builds, they are linked in a different order, which results in an unreproducible build. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
BanzaiMan
pushed a commit
to BanzaiMan/ruby
that referenced
this pull request
Jul 22, 2016
bmwiedemann
pushed a commit
to bmwiedemann/ruby
that referenced
this pull request
Jun 3, 2017
* lib/mkmf.rb (create_makefile): sort lists of source and object files in generated Makefile, unless given by extconf.rb. [Fix rubyGH-1367] Without sorting the list of object files explicitely, its order is indeterministic, because readdir() is also not deterministic. When the list of object files varies between builds, they are linked in a different order, which results in an unreproducible build. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Cherry-picked from trunk commit 15dba48
matzbot
pushed a commit
that referenced
this pull request
Jan 31, 2018
* lib/mkmf.rb (create_makefile): sort lists of source and object files in generated Makefile, unless given by extconf.rb. [Fix GH-1367] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62124 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
zimbatm
added a commit
to zimbatm/ruby
that referenced
this pull request
Oct 25, 2020
This is a continuation of 15dba48 / rubyGH-1367. Without sorting the list of headers explicitly, its order is indeterministic, because readdir() is also not deterministic. When the list of object files varies between builds, it generates a different Makefile, which results in an unreproducible build.
zimbatm
added a commit
to zimbatm/ruby
that referenced
this pull request
Nov 4, 2020
This is a continuation of 15dba48 / rubyGH-1367. Without sorting the list of headers explicitly, its order is indeterministic, because readdir() is also not deterministic. When the list of object files varies between builds, it generates a different Makefile, which results in an unreproducible build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Without sorting the list explicitely, its order is indeterministic,
because readdir() is also not deterministic.
When the list of object files varies between builds, they are linked
in a different order, which results in an unreproducible build.