Options for FTP PORT command #1561

Closed
wants to merge 1 commit into
from

Conversation

2 participants
@s-osa

s-osa commented Mar 29, 2017

I will create a new ticket and write details to it.

@sorah

Please add a test if possible.

lib/net/ftp.rb
@@ -118,6 +118,10 @@ class FTP < Protocol
# If +ssl_handshake_timeout+ is +nil+, +open_timeout+ is used instead.
attr_accessor :ssl_handshake_timeout
+ # Explicit data listening host and port for PORT (or EPRT) command.

This comment has been minimized.

@sorah

sorah Mar 29, 2017

Member

Explicit bind address and port to listen for data. Used for PORT or EPRT command

@sorah

sorah Mar 29, 2017

Member

Explicit bind address and port to listen for data. Used for PORT or EPRT command

@s-osa

This comment has been minimized.

Show comment
Hide comment
@s-osa

s-osa Mar 29, 2017

Changed method transfercmd is private method and it has no test.

s-osa commented Mar 29, 2017

Changed method transfercmd is private method and it has no test.

@s-osa

This comment has been minimized.

Show comment
Hide comment

@s-osa s-osa closed this Dec 4, 2017

@s-osa s-osa deleted the s-osa:ftp_port_command branch Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment