New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find.find -> Use Dir.children instead of Dir.entries #1697

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

1 participant
@esparta

esparta commented Sep 14, 2017

Dir.children is available since Feature #11302. Find.find can
use of the new list (having no '.' neither '..' entries), making
now superflous an if statement.

This change can improve the performance of Find.find when the path
has lots of entries (thousands?).

https://bugs.ruby-lang.org/issues/11302

Find.find -> Use Dir.children instead of Dir.entries
Dir.children is available since Feature #11302. Find.find can
use of the new list (having no '.' neither '..' entries), making
now superflous an if statement.

This change can improve the performance of Find.find when the path
has lots of entries (thousands?).

https://bugs.ruby-lang.org/issues/11302

@matzbot matzbot closed this in b2996b3 Sep 15, 2017

@esparta esparta deleted the esparta:use_dir_children branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment