CAA DNS RR #1732
Closed
CAA DNS RR #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I open issue 14066 on Redmine for that PR |
lib/resolv.rb
Outdated
| # Creates a new CAA for +flag+, +tag+ and +value+. | ||
|
|
||
| def initialize(flag, tag, value) | ||
| @flag, @tag, @value = flag, tag, value |
There was a problem hiding this comment.
Elsewhere in this file assignment to instance variables is done using one line per assignment. Perhaps you want to align with the existing code-style?
Introduce CAA RR DNS record on `Resolv`, defined in [RFC 6844](https://tools.ietf.org/html/rfc6844). Changes on the way `Resource::decode_rdata` works because CAA needs to know the overall RR length, which was previously swallowed.
|
Thanks for this PR, I was also looking for this and so am currently using the patch. Is there anything blocking this from being upstreamed into ruby? CAA is a fairly standard and widely adopted DNS record type now. |
|
I rebased this patch and filed a PR in the upstream repository. ruby/resolv#48 |
|
Thanks @hanazuki ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce CAA RR DNS record on
Resolv, defined in RFC 6844.Changes on the way
Resource::decode_rdataworks because CAA needs to know theoverall RR length, which was previously swallowed.