Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAA DNS RR #1732

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

CAA DNS RR #1732

wants to merge 4 commits into from

Conversation

aeris
Copy link

@aeris aeris commented Oct 29, 2017

Introduce CAA RR DNS record on Resolv, defined in RFC 6844.

Changes on the way Resource::decode_rdata works because CAA needs to know the
overall RR length, which was previously swallowed.

Introduce CAA RR DNS record on `Resolv`, defined in [RFC 6844](https://tools.ietf.org/html/rfc6844).

Changes on the way `Resource::decode_rdata` works because CAA needs to know the
overall RR length, which was previously swallowed.
@aeris
Copy link
Author

aeris commented Oct 29, 2017

I open issue 14066 on Redmine for that PR

lib/resolv.rb Outdated
# Creates a new CAA for +flag+, +tag+ and +value+.

def initialize(flag, tag, value)
@flag, @tag, @value = flag, tag, value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elsewhere in this file assignment to instance variables is done using one line per assignment. Perhaps you want to align with the existing code-style?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

@k0kubun k0kubun changed the base branch from trunk to master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants