Add Matrix#exponentiate method as Matlab's exp method #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzegorz-jakubiak
changed the title
grzegorz-jakubiak
changed the title
Ana06
suggested changes
Nov 20, 2017
lib/matrix.rb
Outdated
| @@ -1254,6 +1254,15 @@ def vstack(*matrices) | |||
| self.class.vstack(self, *matrices) | |||
| end | |||
|
|
|||
| # | |||
| # Returns a matrix with every entry being an exponent of e | |||
There was a problem hiding this comment.
what about component instead of entry? 🤔
lib/matrix.rb
Outdated
| # => Matrix[[2.718281828459045, 1.0], [1.0, 2.718281828459045]] | ||
|
|
||
| def entrywise_exp | ||
| collect{|e| Math.exp(e)} |
There was a problem hiding this comment.
what about calling the variable component? e is normally the letter used for the exponential and it may be confused.
lib/matrix.rb
Outdated
| @@ -1254,6 +1254,15 @@ def vstack(*matrices) | |||
| self.class.vstack(self, *matrices) | |||
| end | |||
|
|
|||
| # | |||
| # Returns a matrix with every entry being an exponent of e | |||
| # Matrix[[1, 0], [0, 1]].entrywise_exp | |||
There was a problem hiding this comment.
You need to add some spaces here this so it is interpreted as code
lib/matrix.rb
Outdated
| # Matrix[[1, 0], [0, 1]].entrywise_exp | ||
| # => Matrix[[2.718281828459045, 1.0], [1.0, 2.718281828459045]] | ||
|
|
||
| def entrywise_exp |
|
@Ana06 Thanks for support! 😃 I've made changes according to what you pointed out. The name of the method was proposed at Ruby Redmine and I simply adopted it but if you've got better name I can change it. |
grzegorz-jakubiak
force-pushed
the
trunk
branch
from
d8f0b4b
to
530514f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prepared a pull request that includes exponentiate method which results in returning a new matrix with each element being an exponent of the number e. This is used e.g in machine learning and other types of calculations. #14116