Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use friendlier terminology in rubysocket.h #2008

Closed
wants to merge 1 commit into from

Conversation

@ioquatix

This comment has been minimized.

Copy link
Member

ioquatix commented Nov 9, 2018

I’m not sure “allowlist” is the right equivalent, because this isn’t about “allowance” but “this has been shown to work”. So, it might just require an entirely new phrasing.

@ioquatix

This comment has been minimized.

Copy link
Member

ioquatix commented Nov 9, 2018

In an effort to find better terminology and to understand the underlying problems, I found https://english.stackexchange.com/questions/51088/alternative-term-to-blacklist-and-whitelist which suggests using "safelist", which I think might be a better fit?

@JuanitoFatas

This comment has been minimized.

Copy link
Member Author

JuanitoFatas commented Nov 10, 2018

In an effort to find better terminology and to understand the underlying problems, I found https://english.stackexchange.com/questions/51088/alternative-term-to-blacklist-and-whitelist which suggests using "safelist", which I think might be a better fit?

Makes sense, applied suggestion, thanks for the review! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.