Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix detection of RL_PROMPT_*_IGNORE macros. #202

Closed
wants to merge 1 commit into
from

Conversation

2 participants

mkmf doesn't create HAVE_X definitions, so HAVE_RL_PROMPT_START_IGNORE
and HAVE_RL_PROMPT_END_IGNORE don't actually get defined by
ext/readline/extconf.rb. Instead, we should detect for
RL_PROMPT_START_IGNORE and RL_PROMPT_END_IGNORE directly.

Fix detection of RL_PROMPT_*_IGNORE macros.
mkmf doesn't create HAVE_X definitions, so HAVE_RL_PROMPT_START_IGNORE
and HAVE_RL_PROMPT_END_IGNORE don't actually get defined by
ext/readline/extconf.rb. Instead, we should detect for
RL_PROMPT_START_IGNORE and RL_PROMPT_END_IGNORE directly.

Any chance this could be merged in to trunk? It would be nice to have colourized prompts available in irb without having to apply custom patches.

Member

zzak commented Nov 19, 2012

I'm closing this, please refer to Bug #7397 in redmine

@zzak zzak closed this Nov 19, 2012

tenderlove added a commit that referenced this pull request Aug 29, 2014

* ext/psych/lib/psych/visitors/to_ruby.rb: merge keys with a hash
  should merge the hash in to the parent.
* test/psych/test_merge_keys.rb: test for change. Fixes GH #202

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47317 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

mmasaki pushed a commit to mmasaki/ruby that referenced this pull request Sep 8, 2014

* ext/psych/lib/psych/visitors/to_ruby.rb: merge keys with a hash
  should merge the hash in to the parent.
* test/psych/test_merge_keys.rb: test for change. Fixes GH #202

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47317 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment