Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XDG_* #2174

Draft
wants to merge 12 commits into
base: trunk
from

Conversation

3 participants
@hsbt
Copy link
Member

commented May 7, 2019

No description provided.

lib/rdoc.rb Outdated
rdoc_dir = File.join homedir, ".rdoc"
end

if File.exists?(rdoc_dir)

This comment has been minimized.

Copy link
@nobu

nobu May 7, 2019

Member

File.exists? is a deprecated name.

@hsbt hsbt force-pushed the hsbt:support-xdg branch from 3b88106 to 0820ad9 Jun 24, 2019

@hsbt hsbt force-pushed the hsbt:support-xdg branch from 159b749 to 4d74234 Jun 25, 2019

@@ -22,7 +22,7 @@ module Gem::GemcutterUtilities
def add_key_option
add_option('-k', '--key KEYNAME', Symbol,
'Use the given API key',
'from ~/.gem/credentials') do |value,options|
'from ~/.config/gem/credentials') do |value,options|

This comment has been minimized.

Copy link
@simi

simi Jun 25, 2019

Does this mean users will need to manually move ~/.gem/credentials to ~/.config/gem/credentials/ or login again?

This comment has been minimized.

Copy link
@hsbt

hsbt Jun 25, 2019

Author Member

No, When the old credential location was available, RubyGems picked it.

see. https://github.com/ruby/ruby/pull/2174/files#diff-f1b45434a730b5cfbe4bac4f88479c7fR280

This comment has been minimized.

Copy link
@simi

simi Jun 25, 2019

Ahh, ok. Thx for clarification. I wasn't sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.