Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolv_timeout to TCPSocket #3472

Closed
wants to merge 1 commit into from

Conversation

mmasaki
Copy link
Member

@mmasaki mmasaki commented Aug 29, 2020

Add resolv_timeout to TCPSocket.new.
It makes DNS timeout customizable in the same way as Socket.tcp.

@mmasaki mmasaki changed the title Add resolve_timeout to TCPSocket Add resolv_timeout to TCPSocket Aug 29, 2020
@mmasaki
Copy link
Member Author

mmasaki commented Sep 25, 2020

merged in 511fe23

@mmasaki mmasaki closed this Sep 25, 2020
@ioquatix
Copy link
Member

ioquatix commented Oct 1, 2020

Great, this seems like useful feature. However, do you think we should call it resolve_timeout?

@mmasaki
Copy link
Member Author

mmasaki commented Oct 1, 2020

I intended to make it consistent with Socket.tcp (it accepts resolv_timeout).

@ioquatix
Copy link
Member

ioquatix commented Oct 1, 2020

When was Socket.tcp with resolv_timeout implemented? It seems like poor naming convention.

@mmasaki
Copy link
Member Author

mmasaki commented Oct 1, 2020

It was in 2019. 0e9d56f
Should we support resolve_timeout instead?

@ioquatix
Copy link
Member

ioquatix commented Oct 1, 2020

I think we should add resolve_timeout including to Socket.tcp and add a deprecation warning for resolv_timeout (it can remain for a while). What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants